GNU bug report logs - #43464
28.0.50; vc: Error calling vc-revert for repo root

Previous Next

Full log

Message #28 received at 43464 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 43464 <at> debbugs.gnu.org
Subject: Re: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root
Date: Tue, 22 Sep 2020 22:48:32 +0300

On 18.09.2020 18:45, Andrii Kolomoiets wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
> 
>> On 18.09.2020 12:30, Andrii Kolomoiets wrote:
>>> Calling `vc-git-revert` or `vc-hg-revert` directly with repo root or any
>>> directory within repo works fine.
>>
>> True. That's how Git and Hg work anyway.
>>
>> I'm not saying the current situation is ideal, but we'd either have to
>> give up any attempt to revert a directory (with a more appropriate
>> message), or somehow differentiate between different backends where it
>> would or wouldn't work.
> 
> BTW vc-revert is also works fine in Git repo when point is on
> subdirectory.  So for the vc-git only reverting repo root is not
> working.

That's an interesting observation.

> Please see attached patch which make it possible for vc-hg to revert
> directory.

Could you explain both changes in that patch?

And also: how does it change, or not change, the behavior of vc-revert 
in backends that are not Git or Hg?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.