GNU bug report logs -
#4344
Highlight escape character sequences in isearch and query-replace
Previous Next
Reported by: Juri Linkov <juri <at> jurta.org>
Date: Fri, 4 Sep 2009 21:25:10 UTC
Severity: normal
Done: Juri Linkov <juri <at> jurta.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your message dated Thu, 10 Sep 2009 03:55:55 +0300
with message-id <87ocpjy5wk.fsf <at> mail.jurta.org>
and subject line Re: bug#4344: Highlight escape character sequences in isearch and query-replace
has caused the Emacs bug report #4344,
regarding Highlight escape character sequences in isearch and query-replace
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)
--
4344: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4344
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
Normally characters sequences using `^' are displayed in the
`escape-glyph' face. However, in isearch and query-replace that both
use `isearch-text-char-description' it is hard to distinguish
escape character sequences visually because they are not highlighted.
Here is a fix:
Index: lisp/isearch.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/isearch.el,v
retrieving revision 1.346
diff -u -r1.346 isearch.el
--- lisp/isearch.el 1 Sep 2009 07:24:19 -0000 1.346
+++ lisp/isearch.el 4 Sep 2009 21:12:37 -0000
@@ -2496,8 +2501,8 @@
(defun isearch-text-char-description (c)
(cond
- ((< c ?\s) (format "^%c" (+ c 64)))
- ((= c ?\^?) "^?")
+ ((< c ?\s) (propertize (format "^%c" (+ c 64)) 'face 'escape-glyph))
+ ((= c ?\^?) (propertize "^?" 'face 'escape-glyph))
(t (char-to-string c))))
;; General function to unread characters or events.
--
Juri Linkov
http://www.jurta.org/emacs/
[Message part 3 (message/rfc822, inline)]
>> Normally characters sequences using `^' are displayed in the
>> `escape-glyph' face. However, in isearch and query-replace that both
>> use `isearch-text-char-description' it is hard to distinguish
>> escape character sequences visually because they are not highlighted.
>> Here is a fix:
>
> Feel free to install it, thanks,
Done.
--
Juri Linkov
http://www.jurta.org/emacs/
This bug report was last modified 15 years and 253 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.