GNU bug report logs - #4344
Highlight escape character sequences in isearch and query-replace

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> jurta.org>

Date: Fri, 4 Sep 2009 21:25:10 UTC

Severity: normal

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4344 in the body.
You can then email your comments to 4344 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4344; Package emacs. (Fri, 04 Sep 2009 21:25:11 GMT) Full text and rfc822 format available.
Acknowledgement sent to Juri Linkov <juri <at> jurta.org>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 04 Sep 2009 21:25:11 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Highlight escape character sequences in isearch and query-replace
Date: Sat, 05 Sep 2009 00:14:38 +0300

Normally characters sequences using `^' are displayed in the
`escape-glyph' face.  However, in isearch and query-replace that both
use `isearch-text-char-description' it is hard to distinguish
escape character sequences visually because they are not highlighted.
Here is a fix:

Index: lisp/isearch.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/isearch.el,v
retrieving revision 1.346
diff -u -r1.346 isearch.el
--- lisp/isearch.el	1 Sep 2009 07:24:19 -0000	1.346
+++ lisp/isearch.el	4 Sep 2009 21:12:37 -0000
@@ -2496,8 +2501,8 @@
 
 (defun isearch-text-char-description (c)
   (cond
-   ((< c ?\s) (format "^%c" (+ c 64)))
-   ((= c ?\^?) "^?")
+   ((< c ?\s) (propertize (format "^%c" (+ c 64)) 'face 'escape-glyph))
+   ((= c ?\^?) (propertize "^?" 'face 'escape-glyph))
    (t (char-to-string c))))
 
 ;; General function to unread characters or events.

-- 
Juri Linkov
http://www.jurta.org/emacs/
Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4344; Package emacs. (Tue, 08 Sep 2009 19:55:06 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Monnier <monnier <at> IRO.UMontreal.CA>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Tue, 08 Sep 2009 19:55:06 GMT) Full text and rfc822 format available.

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4344 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4344: Highlight escape character sequences in isearch and query-replace
Date: Tue, 08 Sep 2009 15:48:57 -0400

> Normally characters sequences using `^' are displayed in the
> `escape-glyph' face.  However, in isearch and query-replace that both
> use `isearch-text-char-description' it is hard to distinguish
> escape character sequences visually because they are not highlighted.
> Here is a fix:

Feel free to install it, thanks,


        Stefan
Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4344; Package emacs. (Tue, 08 Sep 2009 19:55:08 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Monnier <monnier <at> IRO.UMontreal.CA>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Tue, 08 Sep 2009 19:55:08 GMT) Full text and rfc822 format available.
Reply sent to Juri Linkov <juri <at> jurta.org>:
You have taken responsibility. (Thu, 10 Sep 2009 01:05:07 GMT) Full text and rfc822 format available.
Notification sent to Juri Linkov <juri <at> jurta.org>:
bug acknowledged by developer. (Thu, 10 Sep 2009 01:05:07 GMT) Full text and rfc822 format available.

Message #20 received at 4344-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 4344-done <at> debbugs.gnu.org
Subject: Re: bug#4344: Highlight escape character sequences in isearch and query-replace
Date: Thu, 10 Sep 2009 03:55:55 +0300

>> Normally characters sequences using `^' are displayed in the
>> `escape-glyph' face.  However, in isearch and query-replace that both
>> use `isearch-text-char-description' it is hard to distinguish
>> escape character sequences visually because they are not highlighted.
>> Here is a fix:
>
> Feel free to install it, thanks,

Done.

-- 
Juri Linkov
http://www.jurta.org/emacs/
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> emacsbugs.donarmstrong.com. (Thu, 08 Oct 2009 14:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 253 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.