GNU bug report logs - #43188
28.0.50; [PATCH] Don't move point in vc-dir on vc-register/vc-checkin

Previous Next

Package: emacs;

Reported by: Andrii Kolomoiets <andreyk.mad <at> gmail.com>

Date: Thu, 3 Sep 2020 19:23:01 UTC

Severity: minor

Tags: patch

Found in version 28.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43188: closed (28.0.50; [PATCH] Don't move point in vc-dir on
 vc-register/vc-checkin)
Date: Fri, 04 Sep 2020 21:19:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 5 Sep 2020 00:18:16 +0300
with message-id <0c96813e-76d9-6aec-47c5-f2ba81cf2cca <at> yandex.ru>
and subject line Re: bug#43188: 28.0.50; [PATCH] Don't move point in vc-dir on vc-register/vc-checkin
has caused the debbugs.gnu.org bug report #43188,
regarding 28.0.50; [PATCH] Don't move point in vc-dir on vc-register/vc-checkin
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43188: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43188
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Don't move point in vc-dir on vc-register/vc-checkin
Date: Thu, 03 Sep 2020 22:22:20 +0300
[Message part 3 (text/plain, inline)]
Severity: minor

Proposed patch aimed to fix following point movements in vc-dir:

1. Create git repo: mkdir gittest && cd gittest && git init && touch foo.txt
2. Open vc-dir for that repo in Emacs (C-x v d). Point is 1.
3. Run vc-next-action (v).
   Point is moved to 26.
4. revert-buffer (g) to move point to 1.
5. Run vc-next-action (v). Enter commit message and C-c C-c.
   Point is moved to 26 again.
6. Create another file in the repo: touch bar.txt
7. In vc-dir move to the last file: g n n
8. revert-buffer (g)
   Point is moved to the beginning of the line.
9. revert-buffer (g)
   Point is moved to the previous line.


Thanks!
[0001-Don-t-move-point-in-vc-dir-on-vc-register-vc-checkin.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>, 43188-done <at> debbugs.gnu.org
Subject: Re: bug#43188: 28.0.50; [PATCH] Don't move point in vc-dir on
 vc-register/vc-checkin
Date: Sat, 5 Sep 2020 00:18:16 +0300
Version 28.1

On 03.09.2020 22:22, Andrii Kolomoiets wrote:
> Severity: minor
> 
> Proposed patch aimed to fix following point movements in vc-dir:
> 
> 1. Create git repo: mkdir gittest && cd gittest && git init && touch foo.txt
> 2. Open vc-dir for that repo in Emacs (C-x v d). Point is 1.
> 3. Run vc-next-action (v).
>     Point is moved to 26.
> 4. revert-buffer (g) to move point to 1.
> 5. Run vc-next-action (v). Enter commit message and C-c C-c.
>     Point is moved to 26 again.
> 6. Create another file in the repo: touch bar.txt
> 7. In vc-dir move to the last file: g n n
> 8. revert-buffer (g)
>     Point is moved to the beginning of the line.
> 9. revert-buffer (g)
>     Point is moved to the previous line.

Looks like am improvement.

Installed, thanks!


This bug report was last modified 4 years and 263 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.