GNU bug report logs - #43188
28.0.50; [PATCH] Don't move point in vc-dir on vc-register/vc-checkin

Previous Next

Package: emacs;

Reported by: Andrii Kolomoiets <andreyk.mad <at> gmail.com>

Date: Thu, 3 Sep 2020 19:23:01 UTC

Severity: minor

Tags: patch

Found in version 28.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43188 in the body.
You can then email your comments to 43188 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#43188; Package emacs. (Thu, 03 Sep 2020 19:23:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andrii Kolomoiets <andreyk.mad <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 03 Sep 2020 19:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Don't move point in vc-dir on vc-register/vc-checkin
Date: Thu, 03 Sep 2020 22:22:20 +0300
[Message part 1 (text/plain, inline)]
Severity: minor

Proposed patch aimed to fix following point movements in vc-dir:

1. Create git repo: mkdir gittest && cd gittest && git init && touch foo.txt
2. Open vc-dir for that repo in Emacs (C-x v d). Point is 1.
3. Run vc-next-action (v).
   Point is moved to 26.
4. revert-buffer (g) to move point to 1.
5. Run vc-next-action (v). Enter commit message and C-c C-c.
   Point is moved to 26 again.
6. Create another file in the repo: touch bar.txt
7. In vc-dir move to the last file: g n n
8. revert-buffer (g)
   Point is moved to the beginning of the line.
9. revert-buffer (g)
   Point is moved to the previous line.


Thanks!
[0001-Don-t-move-point-in-vc-dir-on-vc-register-vc-checkin.patch (text/x-patch, attachment)]

Reply sent to Dmitry Gutov <dgutov <at> yandex.ru>:
You have taken responsibility. (Fri, 04 Sep 2020 21:19:01 GMT) Full text and rfc822 format available.

Notification sent to Andrii Kolomoiets <andreyk.mad <at> gmail.com>:
bug acknowledged by developer. (Fri, 04 Sep 2020 21:19:02 GMT) Full text and rfc822 format available.

Message #10 received at 43188-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>, 43188-done <at> debbugs.gnu.org
Subject: Re: bug#43188: 28.0.50; [PATCH] Don't move point in vc-dir on
 vc-register/vc-checkin
Date: Sat, 5 Sep 2020 00:18:16 +0300
Version 28.1

On 03.09.2020 22:22, Andrii Kolomoiets wrote:
> Severity: minor
> 
> Proposed patch aimed to fix following point movements in vc-dir:
> 
> 1. Create git repo: mkdir gittest && cd gittest && git init && touch foo.txt
> 2. Open vc-dir for that repo in Emacs (C-x v d). Point is 1.
> 3. Run vc-next-action (v).
>     Point is moved to 26.
> 4. revert-buffer (g) to move point to 1.
> 5. Run vc-next-action (v). Enter commit message and C-c C-c.
>     Point is moved to 26 again.
> 6. Create another file in the repo: touch bar.txt
> 7. In vc-dir move to the last file: g n n
> 8. revert-buffer (g)
>     Point is moved to the beginning of the line.
> 9. revert-buffer (g)
>     Point is moved to the previous line.

Looks like am improvement.

Installed, thanks!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 03 Oct 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 262 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.