GNU bug report logs - #43056
[PATCH] eshell/em-hist.el: Remove unnecessary check

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> mailfence.com>

Date: Wed, 26 Aug 2020 07:35:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 43056 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 43056 <at> debbugs.gnu.org
Subject: Re: bug#43056: [PATCH] eshell/em-hist.el: Remove unnecessary check
Date: Wed, 26 Aug 2020 12:01:39 +0200

Brian Leung <leungbk <at> mailfence.com> writes:

> There's no need to check n here since we're always taking the mod.

[...]

> -      (while (and (< n len) (not tried-each-ring-item)
> +      (while (and (not tried-each-ring-item)

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 273 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.