GNU bug report logs - #43056
[PATCH] eshell/em-hist.el: Remove unnecessary check

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> mailfence.com>

Date: Wed, 26 Aug 2020 07:35:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43056 in the body.
You can then email your comments to 43056 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#43056; Package emacs. (Wed, 26 Aug 2020 07:35:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Brian Leung <leungbk <at> mailfence.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 26 Aug 2020 07:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] eshell/em-hist.el: Remove unnecessary check
Date: Wed, 26 Aug 2020 07:29:03 +0200 (CEST)

[Message part 1 (text/plain, inline)]
There's no need to check n here since we're always taking the mod.

-- 
Sent with https://mailfence.com
Secure and private email
[0001-eshell-Remove-unnecessary-check-in-em-hist.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43056; Package emacs. (Wed, 26 Aug 2020 10:02:01 GMT) Full text and rfc822 format available.

Message #8 received at 43056 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 43056 <at> debbugs.gnu.org
Subject: Re: bug#43056: [PATCH] eshell/em-hist.el: Remove unnecessary check
Date: Wed, 26 Aug 2020 12:01:39 +0200

Brian Leung <leungbk <at> mailfence.com> writes:

> There's no need to check n here since we're always taking the mod.

[...]

> -      (while (and (< n len) (not tried-each-ring-item)
> +      (while (and (not tried-each-ring-item)

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 26 Aug 2020 10:02:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 43056 <at> debbugs.gnu.org and Brian Leung <leungbk <at> mailfence.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 26 Aug 2020 10:02:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 23 Sep 2020 11:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 273 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.