GNU bug report logs - #42960
Add New Package: ronn-ng

Previous Next

Full log

Message #11 received at 42960 <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 42960 <at> debbugs.gnu.org
Subject: Re: [bug#42960] Add New Package: ronn-ng
Date: Fri, 21 Aug 2020 08:13:15 +0545

[Message part 1 (text/plain, inline)]

Hey there,

Thank you very much for the feedback. I have made changes accordingly. ( I
did not want to add the copyright line because I'm still stuck with my 6th
grade email address, but oh well. :D )

Attached is an updated patch.

Thank you!

On Thu, Aug 20, 2020 at 10:55 PM Julien Lepiller <julien <at> lepiller.eu> wrote:

> So I can't try your patch right now, nor cite it in my answer to show you,
> sorry.
>
> From what I see, here are a few comments. Can you fix them and send us an
> updated patch? I'll push as soon as I'm back home this evening.
>
> You should add a copyright line for yourself (unless you already have one,
> I haven't checked the existing file).
>
> The rest is related to whitespace and so. You shouldn't use a newline
> right after add-after. Look at other packages to see how it's done. You've
> left a (begin …) that you probably used for debugging. There's a space in
> the closing parenthesis at the end of tge arguments. The discripcion is
> weirdly formatted: use two spaces after the period, and continue on the
> same line, breaking just before 80 characters.
>
> Thank you!
>
> On 2020年8月20日 11:50:31 GMT-04:00, Prafulla Giri <
> pratheblackdiamond <at> gmail.com> wrote:
>>
>> Esteemed Maintainers,
>>
>> Attached patch contains a definition of ronn-ng.
>>
>> Thank you!
>>
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ronn-ng.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.