GNU bug report logs - #42960
Add New Package: ronn-ng

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42960 in the body.
You can then email your comments to 42960 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Add New Package: ronn-ng
Date: Thu, 20 Aug 2020 21:35:31 +0545

[Message part 1 (text/plain, inline)]

Esteemed Maintainers,

Attached patch contains a definition of ronn-ng.

Thank you!

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ronn-ng.patch (text/x-patch, attachment)]

Message #8 received at 42960 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Prafulla Giri <pratheblackdiamond <at> gmail.com>,42960 <at> debbugs.gnu.org
Subject: Re: [bug#42960] Add New Package: ronn-ng
Date: Thu, 20 Aug 2020 13:10:12 -0400

[Message part 1 (text/plain, inline)]

So I can't try your patch right now, nor cite it in my answer to show you, sorry.

From what I see, here are a few comments. Can you fix them and send us an updated patch? I'll push as soon as I'm back home this evening.

You should add a copyright line for yourself (unless you already have one, I haven't checked the existing file).

The rest is related to whitespace and so. You shouldn't use a newline right after add-after. Look at other packages to see how it's done. You've left a (begin …) that you probably used for debugging. There's a space in the closing parenthesis at the end of tge arguments. The discripcion is weirdly formatted: use two spaces after the period, and continue on the same line, breaking just before 80 characters.

Thank you!

On 2020年8月20日 11:50:31 GMT-04:00, Prafulla Giri <pratheblackdiamond <at> gmail.com> wrote:
>Esteemed Maintainers,
>
>Attached patch contains a definition of ronn-ng.
>
>Thank you!

[Message part 2 (text/html, inline)]

Message #11 received at 42960 <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 42960 <at> debbugs.gnu.org
Subject: Re: [bug#42960] Add New Package: ronn-ng
Date: Fri, 21 Aug 2020 08:13:15 +0545

[Message part 1 (text/plain, inline)]

Hey there,

Thank you very much for the feedback. I have made changes accordingly. ( I
did not want to add the copyright line because I'm still stuck with my 6th
grade email address, but oh well. :D )

Attached is an updated patch.

Thank you!

On Thu, Aug 20, 2020 at 10:55 PM Julien Lepiller <julien <at> lepiller.eu> wrote:

> So I can't try your patch right now, nor cite it in my answer to show you,
> sorry.
>
> From what I see, here are a few comments. Can you fix them and send us an
> updated patch? I'll push as soon as I'm back home this evening.
>
> You should add a copyright line for yourself (unless you already have one,
> I haven't checked the existing file).
>
> The rest is related to whitespace and so. You shouldn't use a newline
> right after add-after. Look at other packages to see how it's done. You've
> left a (begin …) that you probably used for debugging. There's a space in
> the closing parenthesis at the end of tge arguments. The discripcion is
> weirdly formatted: use two spaces after the period, and continue on the
> same line, breaking just before 80 characters.
>
> Thank you!
>
> On 2020年8月20日 11:50:31 GMT-04:00, Prafulla Giri <
> pratheblackdiamond <at> gmail.com> wrote:
>>
>> Esteemed Maintainers,
>>
>> Attached patch contains a definition of ronn-ng.
>>
>> Thank you!
>>
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ronn-ng.patch (text/x-patch, attachment)]

Message #16 received at 42960-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 42960-done <at> debbugs.gnu.org
Cc: Prafulla Giri <pratheblackdiamond <at> gmail.com>
Subject: Re: [bug#42960] Add New Package: ronn-ng
Date: Fri, 21 Aug 2020 14:36:46 +0200

Pushed as c02398edf43c393b858d57c7b9e4839514f85acb on master. Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.