GNU bug report logs - #42887
28.0.50; Customize Group doesn't show/hide option on repeated clicking

Previous Next

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 42887 <at> debbugs.gnu.org, Po Lu <luangruo <at> yahoo.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>, Stefan Kangas <stefankangas <at> gmail.com>, tsuucat <at> icloud.com
Subject: bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking
Date: Fri, 14 Mar 2025 08:55:54 -0300

[Message part 1 (text/plain, inline)]

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> On 11/9/23 15:01, Stefan Kangas wrote:
>> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>>
>>> I don't know why I couldn't reproduce it three years ago, but I managed
>>> to do that now, I think.
>>>
>>> Could you please check if the following change to
>>> widget-button-release-event-p fixes this for you?
>>>
>>> (defun widget-button-release-event-p (event)
>>>    "Non-nil if EVENT is a mouse-button-release event object."
>>>    (and (eventp event)
>>>         (memq (event-basic-type event) '(mouse-1 mouse-2 mouse-3))
>>>         (seq-some (lambda (el)
>>>                     (memq el '(click drag triple double)))
>>>                   (event-modifiers event))))
>>>
>>>
>>> Please do try it with mouse-1 and mouse-2 if you can.
>>>
>>> (I know that the mark gets set with repeating clicks with mouse-1,
>>> and there's a signal with mouse-2, but I'm focusing on whether this
>>> changes fixes the detection of repeated clicks)
>>
>> Thanks.
>>
>> I don't currently have convenient access to the machine where I can
>> reproduce this, and it will be at least another couple of weeks until I
>> do.  Apologies in advance if it takes a while before I can review this.
>

I've improved my fix for this bug, so that it doesn't produce weird
highlights when double clicking a button.

The patch touches a very tricky part of wid-edit.el.  I've been testing
it for a while now, mostly with Customize and some packages of my own.
I haven't found many problems, but I figure it might need some testing
in the outside world.

Furthermore, I don't understand touchscreen commands and I don't have a
way of testing them.  Po Lu, could you please check if the handling of
touchscreen commands are still correct after splitting the functionality
between the down event and the up event?

[0001-Improve-click-handling-in-buffers-with-widgets.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.