GNU bug report logs - #42886
[PATCH 0/1] Need a way to disable iptables for dockerd.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42886 in the body.
You can then email your comments to 42886 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] Need a way to disable iptables for dockerd.
Date: Sun, 16 Aug 2020 10:06:16 +0200

dockerd enables iptables by default, but if you are using nftables, you need
to disable iptables to make it work properly.

With this patch I want to add dockerd argument.

Alexey Abramov (1):
  services: docker: Add 'enable-iptables?' argument.

 gnu/services/docker.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

--
2.27.0

Message #8 received at 42886 <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: 42886 <at> debbugs.gnu.org
Subject: [PATCH 1/1] services: docker: Add 'enable-iptables?' argument.
Date: Sun, 16 Aug 2020 10:09:07 +0200

* gnu/services/docker.scm (docker-configuration): Define the argument.
* gnu/services/docker.scm (docker-shepherd-service): Use it.

Signed-off-by: Alexey Abramov <levenson <at> mmer.org>
---
 gnu/services/docker.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/services/docker.scm b/gnu/services/docker.scm
index 937dff7bdb..98d9c4355b 100644
--- a/gnu/services/docker.scm
+++ b/gnu/services/docker.scm
@@ -56,7 +56,10 @@ loop-back communications.")
    "Enable or disable the user-land proxy (enabled by default).")
   (debug?
    (boolean #f)
-   "Enable or disable debug output."))
+   "Enable or disable debug output.")
+  (enable-iptables?
+   (boolean #t)
+   "Enable addition of iptables rules (enabled by default)"))
 
 (define %docker-accounts
   (list (user-group (name "docker") (system? #t))))
@@ -91,6 +94,7 @@ loop-back communications.")
 (define (docker-shepherd-service config)
   (let* ((docker (docker-configuration-docker config))
          (enable-proxy? (docker-configuration-enable-proxy? config))
+         (enable-iptables? (docker-configuration-enable-iptables? config))
          (proxy (docker-configuration-proxy config))
          (debug? (docker-configuration-debug? config)))
     (shepherd-service
@@ -115,7 +119,8 @@ loop-back communications.")
                                   '())
                            (if #$enable-proxy? "--userland-proxy" "")
                            "--userland-proxy-path" (string-append #$proxy
-                                                                  "/bin/proxy"))
+                                                                  "/bin/proxy")
+                           (if #$enable-iptables? "--iptables" "--iptables=false"))
                      #:pid-file "/var/run/docker.pid"
                      #:log-file "/var/log/docker.log"))
            (stop #~(make-kill-destructor)))))
-- 
2.27.0

Message #13 received at 42886-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: 42886-done <at> debbugs.gnu.org
Subject: Re: [bug#42886] [PATCH 1/1] services: docker: Add 'enable-iptables?'
 argument.
Date: Sun, 16 Aug 2020 11:15:48 +0200

Hello,

> * gnu/services/docker.scm (docker-configuration): Define the argument.
> * gnu/services/docker.scm (docker-shepherd-service): Use it.

I added the corresponding documentation and pushed as
2b68a96422575b14e54c9a7e3d0033f6231a6b4d.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.