GNU bug report logs - #42829
save-some-buffers should learn to "just let go"

Previous Next

To reply to this bug, email your comments to 42829 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: save-some-buffers should learn to "just let go"
Date: Wed, 12 Aug 2020 22:44:17 +0800

emacs-version "26.3". (maybe fixed already?)

C-x s says

  Save file ...documentation.txt? (y, n, !, ., q, C-r, d or C-h)

C-h then says

  Type SPC or ‘y’ to save the current buffer;
  DEL or ‘n’ to skip the current buffer;
  RET or ‘q’ to give up on the save (skip all remaining buffers);
  C-g to quit (cancel the whole command);
  ! to save all remaining buffers;
  C-r to view this buffer;
  d to view changes in this buffer;
  or . (period) to save the current buffer and exit.

Problem is: C-r won't "let go of the user".

He can't just visit the buffer (to say undo his changes there.)
He is still trapped at the prompt. No C-x o won't free him temporarily.

Therefore there needs to be an additional choice:

"v to just visit that file and quit saving the rest of the files if any"

Message #10 received at 42829 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 42829 <at> debbugs.gnu.org
Subject: Re: bug#42829: save-some-buffers should learn to "just let go"
Date: Thu, 13 Aug 2020 02:39:51 +0300

> C-x s says
>
>   Save file ...documentation.txt? (y, n, !, ., q, C-r, d or C-h)
>
> C-h then says
>
>   Type SPC or ‘y’ to save the current buffer;
>   DEL or ‘n’ to skip the current buffer;
>   RET or ‘q’ to give up on the save (skip all remaining buffers);
>   C-g to quit (cancel the whole command);
>   ! to save all remaining buffers;
>   C-r to view this buffer;
>   d to view changes in this buffer;
>   or . (period) to save the current buffer and exit.
>
> Problem is: C-r won't "let go of the user".
>
> He can't just visit the buffer (to say undo his changes there.)
> He is still trapped at the prompt. No C-x o won't free him temporarily.

This means that map-y-or-n-p (used by save-some-buffers) should be rewritten
to rely on read-char-from-minibuffer.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.