GNU bug report logs - #4230
23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4230 in the body.
You can then email your comments to 4230 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate
Date: Fri, 21 Aug 2009 15:45:19 -0700

From the definition of bookmark-handle-bookmark:
 
(let ((file (bookmark-get-filename bookmark)))
         (when file        ;Don't know how to relocate if there's no `file'.
           (setq file (expand-file-name file))
           (ding)
           (if (y-or-n-p (concat (file-name-nondirectory file)
                                 " nonexistent.  Relocate \""
                                 bookmark
                                 "\"? "))
               ...
 
A bookmark can be to a directory or a file. AFAICT, at least on
Windows, you cannot choose a directory using a file selection box - it
insists on a file. Or perhaps there is another kind of file selection
box that allows this, but it is not being used by Emacs.
 
So `use-file-dialog' should be bound to nil around the call to
`y-or-n-p'.
 
I had a bookmark to a directory that needed to be relocated. I tried
to jump to the bookmark by clicking it with the mouse in the list from
`C-x r l'. Because I used the mouse, I got the file dialog box. I
could not find a way to specify a new directory - choosing a directory
just opens the dialog box to the files in the directory, waiting for
you to pick one.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

Message #10 received at 4230-close <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Karl Fogel <kfogel <at> red-bean.com>
To: 4230-close <at> debbugs.gnu.org
Subject: Fixed "bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate"
Date: Sun, 04 Oct 2009 22:39:38 -0400

fixed
--

Thanks for the report.  Fix committed; please test this, as I do not
have a Windows system myself to test it on.

  $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog
  /sources/emacs/emacs/lisp/bookmark.el,v  <--  lisp/bookmark.el
  new revision: 1.130; previous revision: 1.129
  /sources/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
  new revision: 1.16356; previous revision: 1.16355
  Mailing notification to emacs-diffs <at> gnu.org... sent.
  $ 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.