GNU bug report logs - #42011
[PATCH v2] gnu: Add gmic.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vinicius Monego <monego <at> posteo.net>
Subject: bug#42011: closed (Re: [bug#42011] [PATCH v2] gnu: Add gmic.)
Date: Wed, 24 Jun 2020 19:16:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#42011: [PATCH v2] gnu: Add gmic.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 42011 <at> debbugs.gnu.org.

-- 
42011: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42011
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <marius <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>, 42011-done <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: Re: [bug#42011] [PATCH v2] gnu: Add gmic.
Date: Wed, 24 Jun 2020 21:15:29 +0200

[Message part 3 (text/plain, inline)]

Vinicius Monego <monego <at> posteo.net> writes:

> * gnu/packages/image-processing.scm (gmic): New variable.

Applied with the following cosmetic/idiomatic improvements:

[diff (text/x-patch, inline)]

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 64b6395501..a11b1b89d3 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -494,15 +494,14 @@ due to its architecture which automatically parallelises the image workflows.")
     (version "2.9.1")
     (source
      (origin
-      (method url-fetch)
-      (uri (string-append
-            "https://gmic.eu/files/source/gmic_"
-            version ".tar.gz"))
-      (sha256
-       (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
+       (method url-fetch)
+       (uri (string-append "https://gmic.eu/files/source/gmic_"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f)) ;; There are no tests.
+     `(#:tests? #f))                    ;there are no tests
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (inputs
@@ -513,7 +512,7 @@ due to its architecture which automatically parallelises the image workflows.")
        ("libpng" ,libpng)
        ("libtiff" ,libtiff)
        ("libx11" ,libx11)
-       ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI
+       ;;("opencv" ,opencv) ;OpenCV is currently broken in the CI
        ("openexr" ,openexr)
        ("zlib" ,zlib)))
     (home-page "https://gmic.eu/")
@@ -523,8 +522,8 @@ processing.  It provides several user interfaces to convert / manipulate
 / filter / visualize generic image datasets, ranging from 1D scalar
 signals to 3D+t sequences of multi-spectral volumetric images, hence
 including 2D color images.")
-    (license (list license:cecill ;; Dual-licensed, either license applies.
-                   license:cecill-c))))
+    ;; Dual-licensed, either license applies.
+    (license (list license:cecill license:cecill-c))))
 
 (define-public nip2
   (package

[Message part 5 (text/plain, inline)]

Thanks!

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH v2] gnu: Add gmic.
Date: Mon, 22 Jun 2020 19:36:05 -0300

* gnu/packages/image-processing.scm (gmic): New variable.
---
 gnu/packages/image-processing.scm | 39 +++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 801dc70149..64b6395501 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018 Lprndn <guix <at> lprndn.info>
 ;;; Copyright © 2019 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
+;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -487,6 +488,44 @@ quickly, especially on machines with more than one CPU core.  This is primarily
 due to its architecture which automatically parallelises the image workflows.")
     (license license:lgpl2.1+)))
 
+(define-public gmic
+  (package
+    (name "gmic")
+    (version "2.9.1")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append
+            "https://gmic.eu/files/source/gmic_"
+            version ".tar.gz"))
+      (sha256
+       (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f)) ;; There are no tests.
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("curl" ,curl)
+       ("fftw" ,fftw)
+       ("graphicsmagick" ,graphicsmagick)
+       ("libjpeg-turbo" ,libjpeg-turbo)
+       ("libpng" ,libpng)
+       ("libtiff" ,libtiff)
+       ("libx11" ,libx11)
+       ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI
+       ("openexr" ,openexr)
+       ("zlib" ,zlib)))
+    (home-page "https://gmic.eu/")
+    (synopsis "Full-featured framework for digital image processing")
+    (description "G'MIC is a full-featured framework for digital image
+processing.  It provides several user interfaces to convert / manipulate
+/ filter / visualize generic image datasets, ranging from 1D scalar
+signals to 3D+t sequences of multi-spectral volumetric images, hence
+including 2D color images.")
+    (license (list license:cecill ;; Dual-licensed, either license applies.
+                   license:cecill-c))))
+
 (define-public nip2
   (package
     (name "nip2")
-- 
2.20.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.