GNU bug report logs - #42010
28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42010 in the body.
You can then email your comments to 42010 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Doug Davis <ddavis <at> ddavis.io>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; "You should byte-compile Gnus" message for natively
 compiled gnus.el
Date: Mon, 22 Jun 2020 16:52:04 -0400

When running `gnus' with a native compiled Emacs build a message is
reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
is called. I'm not sure what check is possible to see if a function is
natively compiled, but perhaps it should be added to this logic in
gnus.el:

  (unless (byte-code-function-p (symbol-function 'gnus))
    (message "You should byte-compile Gnus")
    (sit-for 2))

Message #8 received at 42010 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Doug Davis <ddavis <at> ddavis.io>
Cc: 42010 <at> debbugs.gnu.org
Subject: Re: bug#42010: 28.0.50;
 "You should byte-compile Gnus" message for natively compiled gnus.el
Date: Mon, 22 Jun 2020 22:41:38 +0000

Doug Davis <ddavis <at> ddavis.io> writes:

> When running `gnus' with a native compiled Emacs build a message is
> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
> is called. I'm not sure what check is possible to see if a function is
> natively compiled, but perhaps it should be added to this logic in
> gnus.el:
>
>   (unless (byte-code-function-p (symbol-function 'gnus))
>     (message "You should byte-compile Gnus")
>     (sit-for 2))

I'll admint that added to my undenaiable laziness I probably skiped this
for so long cause was giving me a tiny satisfaction :)

Should be fixed by:

801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
compilation.

Thanks for the feedback

  Andrea

-- 
akrl <at> sdf.org

Message #11 received at 42010 <at> debbugs.gnu.org (full text, mbox):

From: Arthur Miller <arthur.miller <at> live.com>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 42010 <at> debbugs.gnu.org, Doug Davis <ddavis <at> ddavis.io>
Subject: Re: bug#42010: 28.0.50; "You should byte-compile Gnus" message for
 natively compiled gnus.el
Date: Tue, 23 Jun 2020 08:44:20 +0200

Andrea Corallo <akrl <at> sdf.org> writes:

> Doug Davis <ddavis <at> ddavis.io> writes:
>
>> When running `gnus' with a native compiled Emacs build a message is
>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>> is called. I'm not sure what check is possible to see if a function is
>> natively compiled, but perhaps it should be added to this logic in
>> gnus.el:
>>
>>   (unless (byte-code-function-p (symbol-function 'gnus))
>>     (message "You should byte-compile Gnus")
>>     (sit-for 2))
>
> I'll admint that added to my undenaiable laziness I probably skiped this
> for so long cause was giving me a tiny satisfaction :)
>
> Should be fixed by:
>
> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
> compilation.
>
> Thanks for the feedback
>
>   Andrea
Just rebuild my Emacs and can confirm it if fixed.

Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).

Awesome, thanks Andrea!

Message #16 received at 42010-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Arthur Miller <arthur.miller <at> live.com>
Cc: 42010-done <at> debbugs.gnu.org, Doug Davis <ddavis <at> ddavis.io>
Subject: Re: bug#42010: 28.0.50;
 "You should byte-compile Gnus" message for natively compiled gnus.el
Date: Tue, 23 Jun 2020 07:48:25 +0000

Arthur Miller <arthur.miller <at> live.com> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Doug Davis <ddavis <at> ddavis.io> writes:
>>
>>> When running `gnus' with a native compiled Emacs build a message is
>>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>>> is called. I'm not sure what check is possible to see if a function is
>>> natively compiled, but perhaps it should be added to this logic in
>>> gnus.el:
>>>
>>>   (unless (byte-code-function-p (symbol-function 'gnus))
>>>     (message "You should byte-compile Gnus")
>>>     (sit-for 2))
>>
>> I'll admint that added to my undenaiable laziness I probably skiped this
>> for so long cause was giving me a tiny satisfaction :)
>>
>> Should be fixed by:
>>
>> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
>> compilation.
>>
>> Thanks for the feedback
>>
>>   Andrea
> Just rebuild my Emacs and can confirm it if fixed.
>
> Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).
>
> Awesome, thanks Andrea!

Great, thank you for the testing :)

closing

  Andrea

-- 
akrl <at> sdf.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.