GNU bug report logs - #42010
28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrea Corallo <akrl <at> sdf.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#42010: closed (28.0.50; "You should byte-compile Gnus"
 message for natively compiled gnus.el)
Date: Tue, 23 Jun 2020 07:49:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 23 Jun 2020 07:48:25 +0000
with message-id <xjfh7v2te7q.fsf <at> sdf.org>
and subject line Re: bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
has caused the debbugs.gnu.org bug report #42010,
regarding 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
42010: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42010
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Doug Davis <ddavis <at> ddavis.io>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; "You should byte-compile Gnus" message for natively
 compiled gnus.el
Date: Mon, 22 Jun 2020 16:52:04 -0400

When running `gnus' with a native compiled Emacs build a message is
reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
is called. I'm not sure what check is possible to see if a function is
natively compiled, but perhaps it should be added to this logic in
gnus.el:

  (unless (byte-code-function-p (symbol-function 'gnus))
    (message "You should byte-compile Gnus")
    (sit-for 2))

[Message part 3 (message/rfc822, inline)]

From: Andrea Corallo <akrl <at> sdf.org>
To: Arthur Miller <arthur.miller <at> live.com>
Cc: 42010-done <at> debbugs.gnu.org, Doug Davis <ddavis <at> ddavis.io>
Subject: Re: bug#42010: 28.0.50;
 "You should byte-compile Gnus" message for natively compiled gnus.el
Date: Tue, 23 Jun 2020 07:48:25 +0000

Arthur Miller <arthur.miller <at> live.com> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Doug Davis <ddavis <at> ddavis.io> writes:
>>
>>> When running `gnus' with a native compiled Emacs build a message is
>>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>>> is called. I'm not sure what check is possible to see if a function is
>>> natively compiled, but perhaps it should be added to this logic in
>>> gnus.el:
>>>
>>>   (unless (byte-code-function-p (symbol-function 'gnus))
>>>     (message "You should byte-compile Gnus")
>>>     (sit-for 2))
>>
>> I'll admint that added to my undenaiable laziness I probably skiped this
>> for so long cause was giving me a tiny satisfaction :)
>>
>> Should be fixed by:
>>
>> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
>> compilation.
>>
>> Thanks for the feedback
>>
>>   Andrea
> Just rebuild my Emacs and can confirm it if fixed.
>
> Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).
>
> Awesome, thanks Andrea!

Great, thank you for the testing :)

closing

  Andrea

-- 
akrl <at> sdf.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.