GNU bug report logs - #41977
28.0.50; [PATCH]: eval-when-compile eshell in project.el

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Sun, 21 Jun 2020 11:34:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 41977 <at> debbugs.gnu.org
Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
Date: Sun, 21 Jun 2020 13:25:31 +0100

Theodor Thornhill <theo <at> thornhill.no> writes:

> From 4b3f83a4ea36252f7f7552b58529688f6b4c3c9f Mon Sep 17 00:00:00 2001
> From: Theodor Thornhill <theo <at> thornhill.no>
> Date: Sun, 21 Jun 2020 13:09:42 +0200
> Subject: [PATCH] project.el - eval-when-compile eshell
>
> * lisp/progmodes/project.el: eval-when-compile Eshell so we can use
> 'eshell-buffer-name' in 'project-eshell'

Since eshell-buffer-name is a variable, eval-when-compile is not the
right thing to do here.  Instead, there should be a
(defvar eshell-buffer-name) inside project-eshell declaring the symbol
as special.  Right?

Thanks,

-- 
Basil
This bug report was last modified 5 years and 21 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.