GNU bug report logs - #41977
28.0.50; [PATCH]: eval-when-compile eshell in project.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41977 in the body.
You can then email your comments to 41977 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
Date: Sun, 21 Jun 2020 11:33:06 +0000

[Message part 1 (text/plain, inline)]

Hi!

I saw a little too late that the latest patch to 'project-eshell' didn't
apply correctly when compiling emacs.  As such you would get old
behavior until you eval 'project-eshell'.

A quick fix as far as I can tell is the below patch.

Theo

[0001-project.el-eval-when-compile-eshell.patch (text/x-patch, attachment)]

Message #8 received at 41977 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 41977 <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in
 project.el
Date: Sun, 21 Jun 2020 13:25:31 +0100

Theodor Thornhill <theo <at> thornhill.no> writes:

> From 4b3f83a4ea36252f7f7552b58529688f6b4c3c9f Mon Sep 17 00:00:00 2001
> From: Theodor Thornhill <theo <at> thornhill.no>
> Date: Sun, 21 Jun 2020 13:09:42 +0200
> Subject: [PATCH] project.el - eval-when-compile eshell
>
> * lisp/progmodes/project.el: eval-when-compile Eshell so we can use
> 'eshell-buffer-name' in 'project-eshell'

Since eshell-buffer-name is a variable, eval-when-compile is not the
right thing to do here.  Instead, there should be a
(defvar eshell-buffer-name) inside project-eshell declaring the symbol
as special.  Right?

Thanks,

-- 
Basil

Message #11 received at 41977 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 41977 <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50;
 [PATCH]: eval-when-compile eshell in project.el
Date: Sun, 21 Jun 2020 17:44:24 +0000

[Message part 1 (text/plain, inline)]

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Since eshell-buffer-name is a variable, eval-when-compile is not the
> right thing to do here.  Instead, there should be a
> (defvar eshell-buffer-name) inside project-eshell declaring the symbol
> as special.  Right?

You are absolutely correct, and TIL - thanks :)

Below is another patch doing this. Works fine in emacs -Q


Theo

[0001-Forward-declare-eshell-buffer-name-in-project-eshell.patch (text/x-patch, attachment)]

Message #14 received at 41977 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 41977 <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in
 project.el
Date: Sun, 21 Jun 2020 18:55:34 +0100

Theodor Thornhill <theo <at> thornhill.no> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Since eshell-buffer-name is a variable, eval-when-compile is not the
>> right thing to do here.  Instead, there should be a
>> (defvar eshell-buffer-name) inside project-eshell declaring the symbol
>> as special.  Right?
>
> You are absolutely correct, and TIL - thanks :)
>
> Below is another patch doing this. Works fine in emacs -Q

Thanks, LGTM.

-- 
Basil

Message #19 received at 41977-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>,
 Theodor Thornhill <theo <at> thornhill.no>
Cc: 41977-done <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in
 project.el
Date: Mon, 22 Jun 2020 01:52:15 +0300

On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>> You are absolutely correct, and TIL - thanks:)
>>
>> Below is another patch doing this. Works fine in emacs -Q
> Thanks, LGTM.

Thanks all!

Pushed (after rephrasing the commit message in the imperative mood).

Message #22 received at 41977 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 41977 <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in
 project.el
Date: Mon, 22 Jun 2020 00:02:25 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>>> You are absolutely correct, and TIL - thanks:)
>>>
>>> Below is another patch doing this. Works fine in emacs -Q
>> Thanks, LGTM.
>
> Thanks all!
>
> Pushed (after rephrasing the commit message in the imperative mood).

In the future it should also be rephrased to include a reference to the
bug#number.  ;)

(Sorry, I didn't notice either.)

Thanks,

-- 
Basil

Message #25 received at 41977 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 41977 <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in
 project.el
Date: Mon, 22 Jun 2020 02:07:29 +0300

On 22.06.2020 02:02, Basil L. Contovounesios wrote:
> In the future it should also be rephrased to include a reference to the
> bug#number.;)

Indeed.

I often forget to do this here, especially when working with debbugs. :-(

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.