GNU bug report logs - #41977
28.0.50; [PATCH]: eval-when-compile eshell in project.el

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Sun, 21 Jun 2020 11:34:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 41977 <at> debbugs.gnu.org
Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
Date: Mon, 22 Jun 2020 00:02:25 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>>> You are absolutely correct, and TIL - thanks:)
>>>
>>> Below is another patch doing this. Works fine in emacs -Q
>> Thanks, LGTM.
>
> Thanks all!
>
> Pushed (after rephrasing the commit message in the imperative mood).

In the future it should also be rephrased to include a reference to the
bug#number.  ;)

(Sorry, I didn't notice either.)

Thanks,

-- 
Basil
This bug report was last modified 5 years and 21 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.