GNU bug report logs - #41977
28.0.50; [PATCH]: eval-when-compile eshell in project.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Theodor Thornhill <theo <at> thornhill.no>
Subject: bug#41977: closed (Re: bug#41977: 28.0.50; [PATCH]:
 eval-when-compile eshell in project.el)
Date: Sun, 21 Jun 2020 22:53:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41977 <at> debbugs.gnu.org.

-- 
41977: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41977
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>,
 Theodor Thornhill <theo <at> thornhill.no>
Cc: 41977-done <at> debbugs.gnu.org
Subject: Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in
 project.el
Date: Mon, 22 Jun 2020 01:52:15 +0300

On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>> You are absolutely correct, and TIL - thanks:)
>>
>> Below is another patch doing this. Works fine in emacs -Q
> Thanks, LGTM.

Thanks all!

Pushed (after rephrasing the commit message in the imperative mood).

[Message part 3 (message/rfc822, inline)]

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
Date: Sun, 21 Jun 2020 11:33:06 +0000

[Message part 4 (text/plain, inline)]

Hi!

I saw a little too late that the latest patch to 'project-eshell' didn't
apply correctly when compiling emacs.  As such you would get old
behavior until you eval 'project-eshell'.

A quick fix as far as I can tell is the below patch.

Theo

[0001-project.el-eval-when-compile-eshell.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.