GNU bug report logs - #41671
[PATCH] gnu: Add emacs-glsl-mode

Previous Next

Full log

Message #8 received at 41671 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot <at> gmail.com>
Cc: 41671 <at> debbugs.gnu.org
Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
Date: Tue, 02 Jun 2020 22:04:00 +0200

Hello,

Fredrik Salomonsson <plattfot <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable

Thank you. Some comments follow.

Nitpick: you need full stops at the end of each sentence in the commit
message.

> +         (sha256
> +          (base32
> +           "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))

Nitpick: could you move the hash on the same line as `base32'?

> +      (build-system emacs-build-system)
> +      (home-page
> +       "https://github.com/jimhourihan/glsl-mode")

Nitpick: could you move the URL on the same line as `home-page'?

> +      (synopsis
> +       "Major mode for Open GLSL shader files")

Nitpick: … guess what… ;)

> +      (description
> +       "Major mode for editing OpenGLSL grammar files, usually files ending with
> +`.vert', `.frag', `.glsl', `.geom'.

This should be a complete sentence, e.g.,

  The library provides a major mode…

Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:

  files ending with @file{.vert}, @file{.frag}…

> Is is based on c-mode plus some

Typo and nitpick: "It is based on C mode"

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.