GNU bug report logs - #41671
[PATCH] gnu: Add emacs-glsl-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41671 in the body.
You can then email your comments to 41671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fredrik Salomonsson <plattfot <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Fredrik Salomonsson <plattfot <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-glsl-mode
Date: Tue,  2 Jun 2020 12:41:37 -0700

* gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5f0a0184f9..94fd5cb1c8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22693,6 +22693,34 @@ sense in the @samp{To} and @samp{Cc} headers).  When in the message body, this
 executes a different function (default: @code{indent-relative}).")
       (license license:gpl2+))))
 
+(define-public emacs-glsl-mode
+  ;; No tag, version grabbed from source .el file.
+  (let ((commit "b07112016436d9634cd4ef747f9af6b01366d136")
+        (revision "0"))
+    (package
+      (name "emacs-glsl-mode")
+      (version (git-version "2.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jimhourihan/glsl-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
+      (build-system emacs-build-system)
+      (home-page
+       "https://github.com/jimhourihan/glsl-mode")
+      (synopsis
+       "Major mode for Open GLSL shader files")
+      (description
+       "Major mode for editing OpenGLSL grammar files, usually files ending with
+`.vert', `.frag', `.glsl', `.geom'.  Is is based on c-mode plus some
+features and pre-specified fontifications.")
+      (license license:gpl3+))))
+
 (define-public emacs-gnus-harvest
   (let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d")
         (revision "0"))
-- 
2.26.2

Message #8 received at 41671 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot <at> gmail.com>
Cc: 41671 <at> debbugs.gnu.org
Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
Date: Tue, 02 Jun 2020 22:04:00 +0200

Hello,

Fredrik Salomonsson <plattfot <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable

Thank you. Some comments follow.

Nitpick: you need full stops at the end of each sentence in the commit
message.

> +         (sha256
> +          (base32
> +           "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))

Nitpick: could you move the hash on the same line as `base32'?

> +      (build-system emacs-build-system)
> +      (home-page
> +       "https://github.com/jimhourihan/glsl-mode")

Nitpick: could you move the URL on the same line as `home-page'?

> +      (synopsis
> +       "Major mode for Open GLSL shader files")

Nitpick: … guess what… ;)

> +      (description
> +       "Major mode for editing OpenGLSL grammar files, usually files ending with
> +`.vert', `.frag', `.glsl', `.geom'.

This should be a complete sentence, e.g.,

  The library provides a major mode…

Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:

  files ending with @file{.vert}, @file{.frag}…

> Is is based on c-mode plus some

Typo and nitpick: "It is based on C mode"

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #11 received at 41671 <at> debbugs.gnu.org (full text, mbox):

From: Fredrik Salomonsson <plattfot <at> gmail.com>
To: 41671 <at> debbugs.gnu.org
Cc: Fredrik Salomonsson <plattfot <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-glsl-mode.
Date: Tue,  2 Jun 2020 14:02:49 -0700

* gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5f0a0184f9..2701081b9c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22693,6 +22693,32 @@ sense in the @samp{To} and @samp{Cc} headers).  When in the message body, this
 executes a different function (default: @code{indent-relative}).")
       (license license:gpl2+))))
 
+(define-public emacs-glsl-mode
+  ;; No tag, version grabbed from source .el file.
+  (let ((commit "b07112016436d9634cd4ef747f9af6b01366d136")
+        (revision "0"))
+    (package
+      (name "emacs-glsl-mode")
+      (version (git-version "2.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jimhourihan/glsl-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/jimhourihan/glsl-mode")
+      (synopsis "Major mode for Open GLSL shader files")
+      (description
+       "This package provides a major mode for editing OpenGLSL grammar files,
+usually files ending with @file{.vert}, @file{.frag}, @file{.glsl} or
+@file{.geom}.  It is based on C mode plus some features and pre-specified
+fontifications.")
+      (license license:gpl3+))))
+
 (define-public emacs-gnus-harvest
   (let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d")
         (revision "0"))
-- 
2.26.2

Message #14 received at 41671 <at> debbugs.gnu.org (full text, mbox):

From: Fredrik Salomonsson <plattfot <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 41671 <at> debbugs.gnu.org
Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
Date: Tue, 2 Jun 2020 14:08:33 -0700

[Message part 1 (text/plain, inline)]

Hi Nicolas,

Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:

> Nitpick: you need full stops at the end of each sentence in the commit
> message.
>
> > +         (sha256
> > +          (base32
> > +           "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
>
> Nitpick: could you move the hash on the same line as `base32'?
>
> > +      (build-system emacs-build-system)
> > +      (home-page
> > +       "https://github.com/jimhourihan/glsl-mode")
>
> Nitpick: could you move the URL on the same line as `home-page'?
>
> > +      (synopsis
> > +       "Major mode for Open GLSL shader files")
>
> Nitpick: … guess what… ;)
>
> > +      (description
> > +       "Major mode for editing OpenGLSL grammar files, usually files
> ending with
> > +`.vert', `.frag', `.glsl', `.geom'.
>
> This should be a complete sentence, e.g.,
>
>   The library provides a major mode…
>
> Note that Texinfo syntax for file extensions is @file, so the rest of
> the sentence ought to be:
>
>   files ending with @file{.vert}, @file{.frag}…
>
> > Is is based on c-mode plus some
>
> Typo and nitpick: "It is based on C mode"
>
> Could you send an updated patch?
>

Thank you for the speedy response. I sent in a new patch, which should fix
all the things mentioned above.
Let me know if it ended up in the right place. I'm pretty new with the git
send-email workflow.

-- 
s/Fred[re]+i[ck]+/Fredrik/g

[Message part 2 (text/html, inline)]

Message #19 received at 41671-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot <at> gmail.com>
Cc: 41671-done <at> debbugs.gnu.org
Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode.
Date: Thu, 04 Jun 2020 14:59:14 +0200

This is a duplicate of 41673. I'm closing it, too.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.