GNU bug report logs - #41567
[PATCH] gnu: Add mspdebug.

Previous Next

Package: guix-patches;

Reported by: Morgan.J.Smith <at> outlook.com

Date: Wed, 27 May 2020 19:04:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 41567 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Morgan.J.Smith <at> outlook.com
Cc: 41567 <at> debbugs.gnu.org
Subject: Re: [bug#41567] [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 21:03:21 +0200

[Message part 1 (text/plain, inline)]
Morgan,

Morgan.J.Smith <at> outlook.com 写道：
> +     `(#:phases (modify-phases %standard-phases (delete 
> 'configure) (delete 'check))

Try to keep lines within 80 characters.  Have you heard of our 
lord & saviour ‘guix lint’?  It's nitpicking like this, automated.

There's a more ‘declarative’ way to disable tests.  Add a short 
note why:

 `(#:tests? #f                         ; no test suite
   #:phases
   (modify-phases %standard-phases
     (delete 'configure)))             ; no configure script

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 4 years and 356 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.