GNU bug report logs - #41567
[PATCH] gnu: Add mspdebug.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41567 in the body.
You can then email your comments to 41567 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: Add mspdebug.
Date: Wed, 27 May 2020 13:34:07 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/mspdebug.scm (mspdebug): New variable.
---
 gnu/packages/mspdebug.scm | 44 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 gnu/packages/mspdebug.scm

diff --git a/gnu/packages/mspdebug.scm b/gnu/packages/mspdebug.scm
new file mode 100644
index 0000000000..fcabcae472
--- /dev/null
+++ b/gnu/packages/mspdebug.scm
@@ -0,0 +1,44 @@
+;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
+
+(define-module (gnu packages mspdebug)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages readline))
+
+
+(define-public mspdebug
+  (package
+    (name "mspdebug")
+    (version "0.25")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/dlbeer/mspdebug.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "0prgwb5vx6fd4bj12ss1bbb6axj2kjyriyjxqrzd58s5jyyy8d3c"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases (delete 'configure) (delete 'check))
+       #:make-flags
+       (let ((target ,(%current-target-system)))
+         (list (string-append "CC=" (if target
+                                        (string-append target "-gcc")
+                                        "gcc"))
+               "INSTALL=install"
+               (string-append "PREFIX=" %output)))))
+    (inputs
+     `(("libusb-compat" ,libusb-compat)
+       ("readline" ,readline)))
+    (synopsis "Free debugger for use with MSP430 MCUs")
+    (description "MspDebug supports FET430UIF, eZ430, RF2500 and Olimex
+MSP430-JTAG-TINY programmers, as well as many other compatible
+devices.  It can be used as a proxy for gdb or as an independent
+debugger with support for programming, disassembly and reverse
+engineering.")
+    (home-page "https://github.com/dlbeer/mspdebug")
+    (license gpl2)))
-- 
2.26.2

Message #8 received at 41567 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Morgan.J.Smith <at> outlook.com, 41567 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: Re: [bug#41567] [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 15:53:19 +0200

[Message part 1 (text/plain, inline)]

Morgan.J.Smith <at> outlook.com writes:

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/mspdebug.scm (mspdebug): New variable.

Can you move this package to gnu/packages/debug.scm instead of adding a
new module?

[...]

> +(define-public mspdebug
> +  (package
> +    (name "mspdebug")
> +    (version "0.25")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/dlbeer/mspdebug.git")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "0prgwb5vx6fd4bj12ss1bbb6axj2kjyriyjxqrzd58s5jyyy8d3c"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases (delete 'configure) (delete 'check))
> +       #:make-flags
> +       (let ((target ,(%current-target-system)))
> +         (list (string-append "CC=" (if target
> +                                        (string-append target "-gcc")
> +                                        "gcc"))

Since very recently, you can now use:

  (string-append "CC=" ,(cc-for-target))

instead of the let binding and conditional.

> +               "INSTALL=install"
> +               (string-append "PREFIX=" %output)))))
> +    (inputs
> +     `(("libusb-compat" ,libusb-compat)
> +       ("readline" ,readline)))
> +    (synopsis "Free debugger for use with MSP430 MCUs")

No need to mention free here, since everything in Guix is free
software.  The GitHub tagline is pretty good:

  Debugging tool for MSP430 MCUs

> +    (description "MspDebug supports FET430UIF, eZ430, RF2500 and Olimex
> +MSP430-JTAG-TINY programmers, as well as many other compatible
> +devices.  It can be used as a proxy for gdb or as an independent
> +debugger with support for programming, disassembly and reverse
> +engineering.")
> +    (home-page "https://github.com/dlbeer/mspdebug")
> +    (license gpl2)))

This should be 'gpl2+', since the source files say "GPL 2 or any later
version".

Can you send an updated patch?  Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41567 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Morgan.J.Smith <at> outlook.com
Cc: 41567 <at> debbugs.gnu.org
Subject: Re: [bug#41567] [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 21:03:21 +0200

[Message part 1 (text/plain, inline)]

Morgan,

Morgan.J.Smith <at> outlook.com 写道：
> +     `(#:phases (modify-phases %standard-phases (delete 
> 'configure) (delete 'check))

Try to keep lines within 80 characters.  Have you heard of our 
lord & saviour ‘guix lint’?  It's nitpicking like this, automated.

There's a more ‘declarative’ way to disable tests.  Add a short 
note why:

 `(#:tests? #f                         ; no test suite
   #:phases
   (modify-phases %standard-phases
     (delete 'configure)))             ; no configure script

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 41567 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 41567 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 16:33:52 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/debug.scm (mspdebug): New variable.
---
 gnu/packages/debug.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 4a264427c2..18cc2894a7 100644
--- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2018, 2019 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2019 Pkill -9 <pkill9 <at> runbox.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
+;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -56,6 +57,7 @@
   #:use-module (gnu packages serialization)
   #:use-module (gnu packages virtualization)
   #:use-module (gnu packages xdisorg)
+  #:use-module (gnu packages libusb)
   #:use-module (ice-9 match)
   #:use-module (srfi srfi-1))
 
@@ -596,3 +598,37 @@ GDB with very efficient reverse-execution, which in combination with standard
 GDB/x86 features like hardware data watchpoints, makes debugging much more
 fun.")
     (license license:expat)))
+
+(define-public mspdebug
+  (package
+    (name "mspdebug")
+    (version "0.25")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/dlbeer/mspdebug.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "0prgwb5vx6fd4bj12ss1bbb6axj2kjyriyjxqrzd58s5jyyy8d3c"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                         ; no test suite
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))              ; no configure script
+       #:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             "INSTALL=install"
+             (string-append "PREFIX=" %output))))
+  (inputs
+     `(("libusb-compat" ,libusb-compat)
+       ("readline" ,readline)))
+    (synopsis "Debugging tool for MSP430 MCUs")
+    (description "MspDebug supports FET430UIF, eZ430, RF2500 and Olimex
+MSP430-JTAG-TINY programmers, as well as many other compatible
+devices.  It can be used as a proxy for gdb or as an independent
+debugger with support for programming, disassembly and reverse
+engineering.")
+    (home-page "https://github.com/dlbeer/mspdebug")
+    (license license:gpl2+)))
-- 
2.26.2

Message #19 received at 41567-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Morgan.J.Smith <at> outlook.com, 41567-done <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: Re: [bug#41567] [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 23:18:46 +0200

[Message part 1 (text/plain, inline)]

Morgan.J.Smith <at> outlook.com writes:

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/debug.scm (mspdebug): New variable.

Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.