GNU bug report logs - #41370
27.0.91; Eshell and exit-minibuffer

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: andremegafone <at> gmail.com, alex.branham <at> gmail.com, 41370 <at> debbugs.gnu.org
Subject: bug#41370: 27.0.91; Eshell and exit-minibuffer
Date: Wed, 20 May 2020 21:04:39 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Wed, 20 May 2020 13:31:12 -0400
> Cc: Alex Branham <alex.branham <at> gmail.com>, 41370 <at> debbugs.gnu.org
> 
> This is because eshell-command calls eshell-return-exits-minibuffer
> which does
> 
>     (define-key eshell-mode-map [(control ?m)] 'exit-minibuffer)
> 
> This was okay in 26.3 because eshell-mode created its keymap from
> scratch every time.  That's no longer the case since [1: 1ee0192b792]
> (bugs #22792 and #33808).
> 
> [1: 1ee0192b792]: 2019-08-15 20:49:15 -0400
>   Fix eshell-mode-map initialization
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ee0192b792124663a0a40a729dd83c047d21535
> 
> I think that should be reverted from emacs-27, and the patch below can
> fix it for master:

Agreed, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.