GNU bug report logs - #4130
issues with js2-mode faces

Previous Next

Package: emacs;

Reported by: Steve Yegge <steve.yegge <at> gmail.com>

Date: Wed, 12 Aug 2009 06:00:03 UTC

Severity: normal

Merged with 4097

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4130 in the body.
You can then email your comments to 4130 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4130; Package emacs. (Wed, 12 Aug 2009 06:00:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to Steve Yegge <steve.yegge <at> gmail.com>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Wed, 12 Aug 2009 06:00:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Steve Yegge <steve.yegge <at> gmail.com>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: issues with js2-mode faces
Date: Tue, 11 Aug 2009 22:50:59 -0700

[Message part 1 (text/plain, inline)]
On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu <dann <at> ics.uci.edu> wrote:

>
> js2-mode uses -face suffix for faces.
>
> We are not using this suffix anymore and the tree has been cleaned up of
> such with backward compatibility code added.  This is new code, so
> there's little point in having the suffix...
>

Agree; I'll fix it.  The docs (info pages) are incorrect on a relevant
point,
incidentally; they claim that defining variables whose value is set to the
face of the same name is popular but obsolete; the reality is that
font-lock-add-keywords requires the variable definitions.


>
> Also, instead of defining a new js2-error-face why not just use
> font-lock-warning-face?
>

Why not just define a font-lock-error-face instead?  Other modes
(such as compilation) define their own error faces.  Fix it in Emacs
and the modes will follow.

-steve

[Message part 2 (text/html, inline)]
bug closed, send any further explanations to Steve Yegge <steve.yegge <at> gmail.com> Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> emacsbugs.donarmstrong.com. (Sat, 15 Aug 2009 01:25:05 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> emacsbugs.donarmstrong.com. (Sat, 12 Sep 2009 14:24:43 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 27 Jan 2010 01:53:01 GMT) Full text and rfc822 format available.
Merged 4097 4130. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 27 Jan 2010 01:53:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <bug-gnu-emacs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 24 Feb 2010 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 169 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.