GNU bug report logs - #41179
[PATCH] gnu: Add ecm.

Previous Next

Full log

Message #8 received at 41179 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 41179 <at> debbugs.gnu.org
Subject: Re: [bug#41179] [PATCH] gnu: Add ecm.
Date: Wed, 13 May 2020 11:21:27 +0200

Hello,

> +                    (url "https://github.com/alucryd/ecm-tools")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nnb0c"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f                      ; no check target
> +       #:make-flags (list "CC=gcc"

Hard-coding CC breaks cross-compilation. See 'powerstat' package for how
to fix it.

> +                          (string-append "DESTDIR=" (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda _
> +             (substitute* "Makefile"
> +               (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
> +             #t)))))
> +    (home-page "https://github.com/alucryd/ecm-tools")
> +    (synopsis "Error code modeler")
> +    (description "ECM is a utility that converts ECM files to BIN CD format.")
> +    (license license:gpl3+)))

Maybe you could elaborate a bit on what are ECM files.

Otherwise, seems fine :)

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.