GNU bug report logs - #41179
[PATCH] gnu: Add ecm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41179 in the body.
You can then email your comments to 41179 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: Add ecm.
Date: Sun, 10 May 2020 13:44:50 -0400

* gnu/packages/compression.scm (ecm): New variable.
---
 gnu/packages/compression.scm | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index b599f3a603..a71981374e 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -12,7 +12,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic <dannym <at> scratchpost.org>
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2016 David Craven <david <at> craven.ch>
-;;; Copyright © 2016, 2019 Kei Kebreau <kkebreau <at> posteo.net>
+;;; Copyright © 2016, 2019, 2020 Kei Kebreau <kkebreau <at> posteo.net>
 ;;; Copyright © 2016, 2018, 2019, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 ng0 <ng0 <at> n0.is>
 ;;; Copyright © 2017 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
@@ -2189,3 +2189,33 @@ computations.")
     ;; Blosc itself is released under BSD-3 but it incorporates code under
     ;; other non-copyleft licenses.
     (license license:bsd-3)))
+
+(define-public ecm
+  (package
+    (name "ecm")
+    (version "1.0.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/alucryd/ecm-tools")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nnb0c"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f                      ; no check target
+       #:make-flags (list "CC=gcc"
+                          (string-append "DESTDIR=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda _
+             (substitute* "Makefile"
+               (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
+             #t)))))
+    (home-page "https://github.com/alucryd/ecm-tools")
+    (synopsis "Error code modeler")
+    (description "ECM is a utility that converts ECM files to BIN CD format.")
+    (license license:gpl3+)))
-- 
2.26.0

Message #8 received at 41179 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 41179 <at> debbugs.gnu.org
Subject: Re: [bug#41179] [PATCH] gnu: Add ecm.
Date: Wed, 13 May 2020 11:21:27 +0200

Hello,

> +                    (url "https://github.com/alucryd/ecm-tools")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nnb0c"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f                      ; no check target
> +       #:make-flags (list "CC=gcc"

Hard-coding CC breaks cross-compilation. See 'powerstat' package for how
to fix it.

> +                          (string-append "DESTDIR=" (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda _
> +             (substitute* "Makefile"
> +               (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
> +             #t)))))
> +    (home-page "https://github.com/alucryd/ecm-tools")
> +    (synopsis "Error code modeler")
> +    (description "ECM is a utility that converts ECM files to BIN CD format.")
> +    (license license:gpl3+)))

Maybe you could elaborate a bit on what are ECM files.

Otherwise, seems fine :)

Thanks,

Mathieu

Message #13 received at 41179-done <at> debbugs.gnu.org (full text, mbox):

From: Kei <kkebreau <at> posteo.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 41179-done <at> debbugs.gnu.org
Subject: Re: [bug#41179] [PATCH] gnu: Add ecm.
Date: Wed, 13 May 2020 09:40:02 -0400

On Wed, 2020-05-13 at 11:21 +0200, Mathieu Othacehe wrote:
> Hello,
> 
> > +                    (url "https://github.com/alucryd/ecm-tools")
> > +                    (commit (string-append "v" version))))
> > +              (file-name (git-file-name name version))
> > +              (sha256
> > +               (base32
> > +                "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nn
> > b0c"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     '(#:tests? #f                      ; no check target
> > +       #:make-flags (list "CC=gcc"
> 
> Hard-coding CC breaks cross-compilation. See 'powerstat' package for
> how
> to fix it.
> 

Thanks for the pointer!  It's been fixed.

> > +                          (string-append "DESTDIR=" (assoc-ref
> > %outputs "out")))
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (replace 'configure
> > +           (lambda _
> > +             (substitute* "Makefile"
> > +               (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
> > +             #t)))))
> > +    (home-page "https://github.com/alucryd/ecm-tools")
> > +    (synopsis "Error code modeler")
> > +    (description "ECM is a utility that converts ECM files to BIN
> > CD format.")
> > +    (license license:gpl3+)))
> 
> Maybe you could elaborate a bit on what are ECM files.
> 

Done!

> Otherwise, seems fine :)
> 
> Thanks,
> 
> Mathieu

Thanks for reviewing.  This patch has been pushed to master as commit
3480ceb10a.

Kei

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.