GNU bug report logs - #41151
[PATCH] gnu: vis: Fix #39394

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: tsmish <tsymsh <at> gmail.com>
Subject: bug#41151: closed (Re: [PATCH] gnu: vis: Fix #39394)
Date: Mon, 01 Jun 2020 13:45:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#41151: [PATCH] gnu: vis: Fix #39394

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41151 <at> debbugs.gnu.org.

-- 
41151: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41151
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: tsmish <tsymsh <at> gmail.com>
Cc: 41151-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: vis: Fix #39394
Date: Mon, 1 Jun 2020 15:44:13 +0200

[Message part 3 (text/plain, inline)]

On Sat, May 09, 2020 at 03:51:53PM +0000, tsmish wrote:
> There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
> (#define), which is also in search path
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
> is already set by Makefile to $prefix/share/vis
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

Thanks for the patch! We usually avoid putting a bug number as the only
information in the commit title, so I took the liberty to rewrite the
commit message a bit:

commit 5b588f2c9ba9c40dc32aed7c3cdaa45e8f920509 (HEAD -> master, upstream/master)
Author: tsmish <tsymsh <at> gmail.com>
Date:   Sat May 9 15:51:53 2020 +0000

    gnu: vis: Fix configuration load order.

    * gnu/packages/text-editors.scm (vis)[native-search-paths]: Remove.

    There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
    (#define), which is also in search path
    (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
    is already set by Makefile to $prefix/share/vis
    (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

    This fixes issue https://issues.guix.gnu.org/39394

    Signed-off-by: Jakub Kądziołka <kuba <at> kadziolka.net>

Cheers!

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: tsmish <tsymsh <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: vis: Fix #39394
Date: Sat, 9 May 2020 15:51:53 +0000

There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
(#define), which is also in search path
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
is already set by Makefile to $prefix/share/vis
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

---
 gnu/packages/text-editors.scm | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 886babf3fa..5b17a5082f 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -101,10 +101,6 @@
                  `("LUA_PATH" ":" prefix (,LUA_PATH))
                  `("LUA_CPATH" ":" prefix (,LUA_CPATH)))
                #t))))))
-    (native-search-paths
-     (list (search-path-specification
-            (variable "VIS_PATH")
-            (files '("share/vis")))))
     (inputs `(("lua" ,lua)
               ("ncurses" ,ncurses)
               ("libtermkey" ,libtermkey)
-- 
2.26.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.