GNU bug report logs - #41151
[PATCH] gnu: vis: Fix #39394

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41151 in the body.
You can then email your comments to 41151 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tsmish <tsymsh <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: vis: Fix #39394
Date: Sat, 9 May 2020 15:51:53 +0000

There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
(#define), which is also in search path
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
is already set by Makefile to $prefix/share/vis
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

---
 gnu/packages/text-editors.scm | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 886babf3fa..5b17a5082f 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -101,10 +101,6 @@
                  `("LUA_PATH" ":" prefix (,LUA_PATH))
                  `("LUA_CPATH" ":" prefix (,LUA_CPATH)))
                #t))))))
-    (native-search-paths
-     (list (search-path-specification
-            (variable "VIS_PATH")
-            (files '("share/vis")))))
     (inputs `(("lua" ,lua)
               ("ncurses" ,ncurses)
               ("libtermkey" ,libtermkey)
-- 
2.26.2

Message #10 received at 41151-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: tsmish <tsymsh <at> gmail.com>
Cc: 41151-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: vis: Fix #39394
Date: Mon, 1 Jun 2020 15:44:13 +0200

[Message part 1 (text/plain, inline)]

On Sat, May 09, 2020 at 03:51:53PM +0000, tsmish wrote:
> There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
> (#define), which is also in search path
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
> is already set by Makefile to $prefix/share/vis
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

Thanks for the patch! We usually avoid putting a bug number as the only
information in the commit title, so I took the liberty to rewrite the
commit message a bit:

commit 5b588f2c9ba9c40dc32aed7c3cdaa45e8f920509 (HEAD -> master, upstream/master)
Author: tsmish <tsymsh <at> gmail.com>
Date:   Sat May 9 15:51:53 2020 +0000

    gnu: vis: Fix configuration load order.

    * gnu/packages/text-editors.scm (vis)[native-search-paths]: Remove.

    There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
    (#define), which is also in search path
    (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
    is already set by Makefile to $prefix/share/vis
    (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

    This fixes issue https://issues.guix.gnu.org/39394

    Signed-off-by: Jakub Kądziołka <kuba <at> kadziolka.net>

Cheers!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.