GNU bug report logs - #41095
ERC header line

Previous Next

Package: emacs;

Reported by: philip <at> warpmail.net (Philip K.)

Date: Tue, 5 May 2020 12:47:01 UTC

Severity: wishlist

Tags: fixed

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: philip <at> warpmail.net (Philip K.)
To: 41095 <at> debbugs.gnu.org
Subject: bug#41095: ERC header line
Date: Tue, 05 May 2020 14:46:47 +0200
[Message part 1 (text/plain, inline)]
Hi,

when trying out a dark theme I noticed that the ERC header line was out
of place. It turns out that this is because it's fore- and background
color are hard-coded to gray20 and gray90. Since these are fairly
similar to the default colours of header-line using a light
colour-scheme, I suggest inheriting it's values by default.c

-- 
	Philip K.

[0001-Make-erc-header-line-inherit-from-header-line.patch (text/x-diff, inline)]
From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001
From: Philip K <philip <at> warpmail.net>
Date: Tue, 5 May 2020 14:41:06 +0200
Subject: [PATCH] Make erc-header-line inherit from header-line

---
 lisp/erc/erc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index cfde84e19a..a237ca7ce9 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1212,7 +1212,7 @@ erc-direct-msg-face
   :group 'erc-faces)
 
 (defface erc-header-line
-  '((t :foreground "grey20" :background "grey90"))
+  '((t :inherit header-line))
   "ERC face used for the header line.
 
 This will only be used if `erc-header-line-face-method' is non-nil."
-- 
2.20.1


This bug report was last modified 5 years and 18 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.