GNU bug report logs - #41095
ERC header line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41095 in the body.
You can then email your comments to 41095 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: philip <at> warpmail.net (Philip K.)
To: bug-gnu-emacs <at> gnu.org
Subject: ERC header line
Date: Tue, 05 May 2020 14:46:47 +0200

[Message part 1 (text/plain, inline)]

Hi,

when trying out a dark theme I noticed that the ERC header line was out
of place. It turns out that this is because it's fore- and background
color are hard-coded to gray20 and gray90. Since these are fairly
similar to the default colours of header-line using a light
colour-scheme, I suggest inheriting it's values by default.c

-- 
	Philip K.

[0001-Make-erc-header-line-inherit-from-header-line.patch (text/x-diff, inline)]

From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001
From: Philip K <philip <at> warpmail.net>
Date: Tue, 5 May 2020 14:41:06 +0200
Subject: [PATCH] Make erc-header-line inherit from header-line

---
 lisp/erc/erc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index cfde84e19a..a237ca7ce9 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1212,7 +1212,7 @@ erc-direct-msg-face
   :group 'erc-faces)
 
 (defface erc-header-line
-  '((t :foreground "grey20" :background "grey90"))
+  '((t :inherit header-line))
   "ERC face used for the header line.
 
 This will only be used if `erc-header-line-face-method' is non-nil."
-- 
2.20.1

Message #8 received at 41095 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: philip <at> warpmail.net (Philip K.)
Cc: 41095 <at> debbugs.gnu.org
Subject: Re: bug#41095: ERC header line
Date: Wed, 29 Jul 2020 06:54:51 +0200

philip <at> warpmail.net (Philip K.) writes:

> when trying out a dark theme I noticed that the ERC header line was out
> of place. It turns out that this is because it's fore- and background
> color are hard-coded to gray20 and gray90. Since these are fairly
> similar to the default colours of header-line using a light
> colour-scheme, I suggest inheriting it's values by default.c

[...]

>  (defface erc-header-line
> -  '((t :foreground "grey20" :background "grey90"))
> +  '((t :inherit header-line))
>    "ERC face used for the header line.

This also makes the header line look less awkward in dark mode, so it
makes sense to me.  Applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.