GNU bug report logs - #41033
[PATCH] gnu: libusb-0.1: fix build failure on newer gcc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41033 in the body.
You can then email your comments to 41033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Howard <christopher <at> librehacker.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
Date: Sat, 02 May 2020 14:47:56 -0800

[Message part 1 (text/plain, inline)]

I need libusb-0.1 to build some older software, but libusb-0.1 build
fails due to a warning from the current GCC version. (Evidently libusb-
0.1 is set to die on any warning.) The attached patch silences the
warning.

-- 
Christopher Howard
p: +1 (907) 374-0257
w: https://librehacker.com
social: https://gnusocial.club/librehacker
gpg: ADDEAADE5D607C8D (keys.gnupg.net)

[0001-gnu-libusb-0.1-fix-build-failure-on-newer-gcc.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Christopher Howard <christopher <at> librehacker.com>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
Date: Sun, 3 May 2020 12:58:46 +0200

[Message part 1 (text/plain, inline)]

On Sat, May 02, 2020 at 02:47:56PM -0800, Christopher Howard wrote:
> I need libusb-0.1 to build some older software, but libusb-0.1 build
> fails due to a warning from the current GCC version. (Evidently libusb-
> 0.1 is set to die on any warning.) The attached patch silences the
> warning.

Thanks for your patch! I'm wondering though, whether it wouldn't be more
resilient to add a -Wno-error flag instead. After all, the compiler is
going to get upgraded sooner or later, which will introduce new
warnings, and libusb 0.1 isn't getting any upgrades...

A quick grep suggests that this wouldn't be the first package to disable
Werror. Makes sense, since this mode is mostly useful to developers, and
not packagers.

What do you think?

Kind regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Howard <christopher <at> librehacker.com>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
Date: Sun, 03 May 2020 08:13:32 -0800

Sounds good to me. Can you make the edit to the patch?

-- 
Christopher Howard
p: +1 (907) 374-0257
w: https://librehacker.com
social: https://gnusocial.club/librehacker
gpg: ADDEAADE5D607C8D (keys.gnupg.net)

On Sun, 2020-05-03 at 12:58 +0200, Jakub Kądziołka wrote:
> On Sat, May 02, 2020 at 02:47:56PM -0800, Christopher Howard wrote:
> > I need libusb-0.1 to build some older software, but libusb-0.1
> > build
> > fails due to a warning from the current GCC version. (Evidently
> > libusb-
> > 0.1 is set to die on any warning.) The attached patch silences the
> > warning.
> 
> Thanks for your patch! I'm wondering though, whether it wouldn't be
> more
> resilient to add a -Wno-error flag instead. After all, the compiler
> is
> going to get upgraded sooner or later, which will introduce new
> warnings, and libusb 0.1 isn't getting any upgrades...
> 
> A quick grep suggests that this wouldn't be the first package to
> disable
> Werror. Makes sense, since this mode is mostly useful to developers,
> and
> not packagers.
> 
> What do you think?
> 
> Kind regards,
> Jakub Kądziołka

Message #16 received at 41033-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Christopher Howard <christopher <at> librehacker.com>
Cc: 41033-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
Date: Sun, 3 May 2020 22:56:59 +0200

[Message part 1 (text/plain, inline)]

On Sun, May 03, 2020 at 08:13:32AM -0800, Christopher Howard wrote:
> Sounds good to me. Can you make the edit to the patch?

Sure! I pushed the modified patch:

commit 96e399ee30251a0767a45b2bde3f052b25c62714 (HEAD -> master, upstream/master)
Author: Christopher Howard <christopher <at> librehacker.com>
Date:   Sat May 2 14:41:00 2020 -0800

    gnu: libusb-0.1: fix build failure on newer gcc

    * gnu/packages/libusb.scm (libusb-0.1): Disable -Werror.

    Signed-off-by: Jakub Kądziołka <kuba <at> kadziolka.net>

Cheers!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.