GNU bug report logs - #41032
[PATCH] Add makepasswd package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41032 in the body.
You can then email your comments to 41032 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean-Baptiste Note <jean-baptiste.note <at> m4x.org>
To: guixpatch <guix-patches <at> gnu.org>
Subject: [PATCH] Add makepasswd package
Date: Sat, 02 May 2020 20:37:28 +0000

[Message part 1 (text/plain, inline)]

Dear Guix maintainers,

Here is an attempt at packaging makepasswd, a run-time dependency of
x2go.

I've placed it in its own file which may be ill-advised for now; please
let me know where I could more sensibly move it.

Hopefully patches will follow that put more flesh in this x2go.scm file;
however I find this program useful in its own right.

Kind regards,
Jean-Baptiste

[0001-x2go-Add-makepasswd.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41032 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jean-Baptiste Note <jean-baptiste.note <at> m4x.org>, 41032 <at> debbugs.gnu.org
Subject: Re: [bug#41032] [PATCH] Add makepasswd package
Date: Tue, 05 May 2020 18:49:59 +0200

[Message part 1 (text/plain, inline)]

Jean-Baptiste Note <jean-baptiste.note <at> m4x.org> writes:

> Dear Guix maintainers,
>
> Here is an attempt at packaging makepasswd, a run-time dependency of
> x2go.
>
> I've placed it in its own file which may be ill-advised for now; please
> let me know where I could more sensibly move it.

Perhaps password-utils.scm could work for this package?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41032 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Baptiste Note <jean-baptiste.note <at> m4x.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 41032 <at> debbugs.gnu.org
Subject: Re: [bug#41032] [PATCH] Add makepasswd package
Date: Tue, 05 May 2020 18:47:35 +0000

[Message part 1 (text/plain, inline)]

Hi Marius,

Thanks for your review and the heads up on the correct file.
Please find an updated patch.

I've used guix-devel-mode and ran indent-according-to-mode on the buffer
before producing the patch; let me know if this is not sufficient to
correctly indent the code :)

Kind regards,
Jean-Baptiste

[0001-gnu-Add-makepasswd.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 41032-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jean-Baptiste Note <jean-baptiste.note <at> m4x.org>
Cc: 41032-done <at> debbugs.gnu.org
Subject: Re: [bug#41032] [PATCH] Add makepasswd package
Date: Wed, 06 May 2020 22:29:58 +0200

[Message part 1 (text/plain, inline)]

Jean-Baptiste Note <jean-baptiste.note <at> m4x.org> writes:

> Hi Marius,
>
> Thanks for your review and the heads up on the correct file.
> Please find an updated patch.
>
> I've used guix-devel-mode and ran indent-according-to-mode on the buffer
> before producing the patch; let me know if this is not sufficient to
> correctly indent the code :)

Thanks!  My Emacs agrees, so LGTM.

[...]

> +      (arguments
> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure))
> +         #:make-flags (list "CC=gcc" (string-append "PREFIX=" (assoc-ref %outputs "out")))

I moved the second flag to its own line as 89 characters is a bit much.

> +         #:tests? #f))

And added a comment about why tests are disabled.

> +      (synopsis "Generate (pseudo-)random passwords and hashes")
> +      (description
> +       "Makepasswd is a program that generates pseudo-random passwords of a
> +desired length.  It can also generate their corresponding hashes for a given
> +encryption algorithm if so desired.")
> +      (home-page "https://github.com/khorben/makepasswd")
> +      (license license:gpl3))))

Indeed GPL3 only :-/

Applied!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.