GNU bug report logs - #40993
cuirass: Add build products download support.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <m.othacehe <at> gmail.com>

Date: Fri, 1 May 2020 08:56:02 UTC

Severity: normal

Done: Mathieu Othacehe <mathieu <at> meru.i-did-not-set--mail-host-address--so-tickle-me>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 40993 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: ludo <at> gnu.org, 40993 <at> debbugs.gnu.org
Subject: Re: [bug#40993] cuirass: Add build products download support.
Date: Fri, 1 May 2020 12:09:14 +0200

[Message part 1 (text/plain, inline)]
Hi Mathieu,

very cool!

Though I agree using sendfile would be much better, especially since the user
can download 800 MB image files there.

The guile (web server) module allows passing a procedure as the #:body, but
then it makes a bytevector out of the result and hard-codes the content-type :P.

Eventually (web server http) http-write is reached, which only supports encoding
bytevectors and #f, that's it.  No files.

So we'd have to overwrite http-write.

But we are using our own (web server fiberized) impl already.

So our impl chould be extended to be able to get and process FDs.

client-loop there has

              (lambda (response body)
                (write-response response client)
                (when body
                  (put-bytevector client body))

which means the "when body" part should be extended to also handle files, not just bytevectors.

[Message part 2 (application/pgp-signature, inline)]
This bug report was last modified 4 years and 340 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.