GNU bug report logs - #40994
Programs With Movie Titles (PWMT)

Previous Next

To reply to this bug, email your comments to 40994 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: Programs With Movie Titles (PWMT)
Date: Fri, 1 May 2020 07:52:53 -0400

Hello Guix!

I am starting this thread for my patches regarding programs that belong to PWMT
Project (pwmt.org). The programs are Girara, Jumanji and Zathura.

I will be creating a new module, named, pwmt.scm. This is to put all PWMT
packages together. The concept here is similar to suckless.scm.

I will be sending patches one-by-one in this thread; with numbered prefix [N].
These patches are to be pushed in ascending order.

Thank you!

Regards,
RG.

Message #8 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 1-girara-v1
Date: Fri, 1 May 2020 09:49:48 -0400

[Message part 1 (text/plain, inline)]

[1-giara-v1.patch (text/x-patch, attachment)]

Message #11 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 2-zathura-v1
Date: Fri, 1 May 2020 09:50:49 -0400

[Message part 1 (text/plain, inline)]

[2-zathura-v1.patch (text/x-patch, attachment)]

Message #14 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 3-zathura-ps-v1
Date: Fri, 1 May 2020 13:48:42 -0400

[Message part 1 (text/plain, inline)]

[3-zathura-ps-v1.patch (text/x-patch, attachment)]

Message #17 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 4-zathura-pdf-poppler-v1
Date: Sat, 2 May 2020 04:17:55 -0400

[Message part 1 (text/plain, inline)]

[4-zathura-pdf-poppler-v1.patch (text/x-patch, attachment)]

Message #20 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 5-zathura-pdf-mupdf-v1
Date: Sat, 2 May 2020 04:50:17 -0400

[Message part 1 (text/plain, inline)]

[5-zathura-pdf-mupdf-v1.patch (text/x-patch, attachment)]

Message #23 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 6-zathura-djvu-v1
Date: Sat, 2 May 2020 05:16:07 -0400

[Message part 1 (text/plain, inline)]

[6-zathura-djvu-v1.patch (text/x-patch, attachment)]

Message #26 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: 7-zathura-cb-v1
Date: Sat, 2 May 2020 05:58:54 -0400

[Message part 1 (text/plain, inline)]

[7-zathura-cb-v1.patch (text/x-patch, attachment)]

Message #29 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 40994 <at> debbugs.gnu.org, raghavgururajan <at> disroot.org
Subject: Re: patch#40994 Programs With Movie Titles (PWMT)
Date: Sat, 02 May 2020 13:24:05 +0000

Hello Raghav,

> I am starting this thread for my patches regarding programs that belong 
> to
> PWMT Project (pwmt.org). The programs are Girara, Jumanji and Zathura.

I don't see a patch related to jumanji, is it voluntary?

> I will be creating a new module, named, pwmt.scm. This is to put all 
> PWMT
> packages together. The concept here is similar to suckless.scm.
> 
> I will be sending patches one-by-one in this thread; with numbered 
> prefix [N].
> These patches are to be pushed in ascending order.

Could you take example on a commit like
aff0cce9175aaf836dd78941eb17549e3bfa7188 (there must be others like it)
which move packages to a separate module. In particular create a commit
that just move the packages in the new module and adjust the modules 
that
depend on them (if any). Then add your modifications to the packages in
separate commits to the one moving them with the git messages correctly
formatted, ie. not in a free form style. Otherwise it's difficult to
understand what your package modifications are related to just moving 
them
elsewhere,since it's just a big diff.

- Brice.

Message #32 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40994 <at> debbugs.gnu.org
Subject: Re: patch#40994 Programs With Movie Titles (PWMT)
Date: Sat, 2 May 2020 12:09:01 -0400

[Message part 1 (text/plain, inline)]

Hi Brice!

> I don't see a patch related to jumanji, is it voluntary?

I tried packaging Jumanji, but it is ported to new versions of webkitgtk. We do
not have older versions of webkitgtk in guix.

> Could you take example on a commit like
> aff0cce9175aaf836dd78941eb17549e3bfa7188 (there must be others like it)
> which move packages to a separate module. In particular create a commit
> that just move the packages in the new module and adjust the modules 
> that
> depend on them (if any). Then add your modifications to the packages in
> separate commits to the one moving them with the git messages correctly
> formatted, ie. not in a free form style. Otherwise it's difficult to
> understand what your package modifications are related to just moving 
> them
> elsewhere,since it's just a big diff.

Thanks for the feedback. Sure thing!

Please find the attachments with this email, for moving stuffs. All the moved
packages only refer to each other. So no need of altering any other package
definitions.

I will send another set of patches for modifying stuffs,

Thank you!

Regards,
RG.

[0001-gnu-Move-girara-from-gtk.scm-to-pwmt.scm.patch (text/x-patch, attachment)]

[0002-gnu-Move-zathura-from-pdf.scm-to-pwmt.scm.patch (text/x-patch, attachment)]

[0003-gnu-Move-zathura-ps-from-pdf.scm-to-pwmt.scm.patch (text/x-patch, attachment)]

[0004-gnu-Move-zathura-pdf-poppler-from-pdf.scm-to-pwmt.sc.patch (text/x-patch, attachment)]

[0005-gnu-Move-zathura-pdf-mupdf-from-pdf.scm-to-pwmt.scm.patch (text/x-patch, attachment)]

[0006-gnu-Move-zathura-djvu-from-pdf.scm-to-pwmt.scm.patch (text/x-patch, attachment)]

[0007-gnu-Move-zathura-cb-from-pdf.scm-to-pwmt.scm.patch (text/x-patch, attachment)]

Message #35 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40994 <at> debbugs.gnu.org
Subject: Re: patch#40994 Programs With Movie Titles (PWMT)
Date: Sun, 3 May 2020 00:22:40 -0400

[Message part 1 (text/plain, inline)]

Hi Brice!

> > I don't see a patch related to jumanji, is it voluntary?
> 
> I tried packaging Jumanji, but it is ported to new versions of webkitgtk. We
> do not have older versions of webkitgtk in guix.
> 
> > Could you take example on a commit like
> > aff0cce9175aaf836dd78941eb17549e3bfa7188 (there must be others like it)
> > which move packages to a separate module. In particular create a commit
> > that just move the packages in the new module and adjust the modules 
> > that
> > depend on them (if any). Then add your modifications to the packages in
> > separate commits to the one moving them with the git messages correctly
> > formatted, ie. not in a free form style. Otherwise it's difficult to
> > understand what your package modifications are related to just moving 
> > them
> > elsewhere,since it's just a big diff.
> 
> Thanks for the feedback. Sure thing!
> 
> Please find the attachments with this email, for moving stuffs. All the moved
> packages only refer to each other. So no need of altering any other package
> definitions.
> 
> I will send another set of patches for modifying stuffs,
> 

Here, I have attached another patch-set for modifying stuffs. :-)

Regards,
RG.

[0008-gnu-girara-Update-package-definition.patch (text/x-patch, attachment)]

[0009-gnu-zathura-Update-package-definition.patch (text/x-patch, attachment)]

[0010-gnu-zathura-ps-Update-package-definition.patch (text/x-patch, attachment)]

[0011-gnu-zathura-pdf-poppler-Update-package-definition.patch (text/x-patch, attachment)]

[0012-gnu-zathura-pdf-mupdf-Update-package-definition.patch (text/x-patch, attachment)]

[0013-gnu-zathura-djvu-Update-package-definition.patch (text/x-patch, attachment)]

[0014-gnu-zathura-cb-Update-package-definition.patch (text/x-patch, attachment)]

Message #38 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Subject: All patches attached
Date: Wed, 6 May 2020 05:41:19 -0400

[Message part 1 (text/plain, inline)]

[1.patch (text/x-patch, attachment)]

[2.patch (text/x-patch, attachment)]

[3.patch (text/x-patch, attachment)]

[4.patch (text/x-patch, attachment)]

[5.patch (text/x-patch, attachment)]

[6.patch (text/x-patch, attachment)]

[7.patch (text/x-patch, attachment)]

[8.patch (text/x-patch, attachment)]

[9.patch (text/x-patch, attachment)]

[10.patch (text/x-patch, attachment)]

[11.patch (text/x-patch, attachment)]

[12.patch (text/x-patch, attachment)]

[13.patch (text/x-patch, attachment)]

[14.patch (text/x-patch, attachment)]

Message #41 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>,
 Brice Waegeneire <brice <at> waegenei.re>
Cc: 40994 <at> debbugs.gnu.org
Subject: Re: [bug#40994] patch#40994 Programs With Movie Titles (PWMT)
Date: Wed, 06 May 2020 21:29:21 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

Raghav Gururajan <raghavgururajan <at> disroot.org> writes:

> Please find the attachments with this email, for moving stuffs. All the moved
> packages only refer to each other. So no need of altering any other package
> definitions.

I'm not convinced that moving these packages are worth the effort,
though I'm not opposed to it either.  What is the rationale?

I do have a few nits to pick though :-)

> From a05c5d174a9ee40e433a64c50f19c7f106381903 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 2 May 2020 11:16:04 -0400
> Subject: [PATCH 1/7] gnu: Move girara from gtk.scm to pwmt.scm.
>
> * gnu/packages/gtk.scm (girara): Move to [...]
> * gnu/packages/pwmt.scm (girara): [...] here.
> ---
>  gnu/packages/gtk.scm  | 49 -----------------------
>  gnu/packages/pwmt.scm | 91 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 91 insertions(+), 49 deletions(-)
>  create mode 100644 gnu/packages/pwmt.scm
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index bea4850d15..4d093a0e0a 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1445,55 +1445,6 @@ In addition to the low level layout rendering routines, Pango includes
>  and routines to assist in editing internationalized text.")
>      (license license:lgpl2.1+)))
>  
> -(define-public girara
> -  (package
> -    (name "girara")
> -    (version "0.3.4")
> -    (source
> -     (origin
> -       (method git-fetch)
> -       (uri (git-reference
> -             (url "https://git.pwmt.org/pwmt/girara")
> -             (commit version)))
> -       (file-name (git-file-name name version))
> -       (sha256
> -        (base32 "08rpw9hkaprm4r853xy1d35i2af1pji8c3mzzl01mmwmyr9p0x8k"))))
> -    (native-inputs `(("pkg-config" ,pkg-config)
> -                     ("check" ,check)
> -                     ("gettext" ,gettext-minimal)
> -                     ("glib:bin" ,glib "bin")
> -                     ("xorg-server" ,xorg-server-for-tests)))
> -    ;; Listed in 'Requires.private' of 'girara.pc'.
> -    (propagated-inputs `(("gtk+" ,gtk+)))
> -    (arguments
> -     `(#:phases (modify-phases %standard-phases
> -                  (add-before 'check 'start-xserver
> -                    ;; Tests require a running X server.
> -                    (lambda* (#:key inputs #:allow-other-keys)
> -                      (let ((xorg-server (assoc-ref inputs "xorg-server"))
> -                            (display ":1"))
> -                        (setenv "DISPLAY" display)
> -
> -                        ;; On busy machines, tests may take longer than
> -                        ;; the default of four seconds.
> -                        (setenv "CK_DEFAULT_TIMEOUT" "20")
> -
> -                        ;; Don't fail due to missing '/etc/machine-id'.
> -                        (setenv "DBUS_FATAL_WARNINGS" "0")
> -                        (zero? (system (string-append xorg-server "/bin/Xvfb "
> -                                                      display " &")))))))))
> -    (build-system meson-build-system)
> -    (home-page "https://pwmt.org/projects/girara/")
> -    (synopsis "Library for minimalistic gtk+3 user interfaces")
> -    (description "Girara is a library that implements a user interface that
> -focuses on simplicity and minimalism.  Currently based on GTK+, a
> -cross-platform widget toolkit, it provides an interface that focuses on three
> -main components: a so-called view widget that represents the actual
> -application, an input bar that is used to execute commands of the
> -application and the status bar which provides the user with current
> -information.")
> -    (license license:zlib)))
> -
>  (define-public gtk-doc
>    (package
>      (name "gtk-doc")
> diff --git a/gnu/packages/pwmt.scm b/gnu/packages/pwmt.scm
> new file mode 100644
> index 0000000000..8185cc40d9
> --- /dev/null
> +++ b/gnu/packages/pwmt.scm
> @@ -0,0 +1,91 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;;
> +;;; Copyright © 2015 Paul van der Walt <paul <at> denknerd.org>
> +;;; Copyright © 2016 ng0 <ng0 <at> we.make.ritual.n0.is>
> +;;; Copyright © 2017 2018 Marius Bakke <mbakke <at> fastmail.com>
> +;;; Copyright © 2017 Kei Kebreau <kei <at> openmailbox.org>
> +;;; Copyright © 2018 2019 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
> +;;; Copyright © 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>

For each patch, please include the copyright information for that
package only.  I don't think all of these people worked on girara.

That makes it easier to track when someone decides to move these
packages to gtk.scm and pdf.scm in the future.  ;-)

> +(define-module (gnu packages pwmt)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages check)
> +  #:use-module (gnu packages documentation)
> +  #:use-module (gnu packages gettext)
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gnome)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages web)
> +  #:use-module (gnu packages xorg)
> +  #:use-module (gnu packages xdisorg)

Likewise for modules: gnome, web, xorg and xdisorg seems unused for
girara. 

> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)

And (guix download).

> +  #:use-module (guix git-download)
> +  #:use-module (guix build-system gnu)

And gnu-build-system.

> +  #:use-module (guix build-system meson))
> +
> +(define-public girara
> +  (package
> +    (name "girara")
> +    (version "0.3.4")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.pwmt.org/pwmt/girara")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "08rpw9hkaprm4r853xy1d35i2af1pji8c3mzzl01mmwmyr9p0x8k"))))
> +    (native-inputs `(("pkg-config" ,pkg-config)
> +                     ("check" ,check)
> +                     ("gettext" ,gettext-minimal)
> +                     ("glib:bin" ,glib "bin")
> +                     ("xorg-server" ,xorg-server-for-tests)))
> +    ;; Listed in 'Requires.private' of 'girara.pc'.
> +    (propagated-inputs `(("gtk+" ,gtk+)))
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before 'check 'start-xserver
> +                    ;; Tests require a running X server.
> +                    (lambda* (#:key inputs #:allow-other-keys)
> +                      (let ((xorg-server (assoc-ref inputs "xorg-server"))
> +                            (display ":1"))
> +                        (setenv "DISPLAY" display)
> +
> +                        ;; On busy machines, tests may take longer than
> +                        ;; the default of four seconds.
> +                        (setenv "CK_DEFAULT_TIMEOUT" "20")
> +
> +                        ;; Don't fail due to missing '/etc/machine-id'.
> +                        (setenv "DBUS_FATAL_WARNINGS" "0")
> +                        (zero? (system (string-append xorg-server "/bin/Xvfb "
> +                                                      display " &")))))))))
> +    (build-system meson-build-system)
> +    (home-page "https://pwmt.org/projects/girara/")
> +    (synopsis "Library for minimalistic gtk+3 user interfaces")
> +    (description "Girara is a library that implements a user interface that
> +focuses on simplicity and minimalism.  Currently based on GTK+, a
> +cross-platform widget toolkit, it provides an interface that focuses on three
> +main components: a so-called view widget that represents the actual
> +application, an input bar that is used to execute commands of the
> +application and the status bar which provides the user with current
> +information.")
> +    (license license:zlib)))
> \ No newline at end of file

Also make sure that the files end with a newline, like all other files
in Guix.

For the remainder in this series, please also check whether module
imports can be removed from pdf.scm (that makes it worth it IMO).

[signature.asc (application/pgp-signature, inline)]

Message #44 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>,
 Brice Waegeneire <brice <at> waegenei.re>
Cc: 40994 <at> debbugs.gnu.org
Subject: Re: [bug#40994] patch#40994 Programs With Movie Titles (PWMT)
Date: Wed, 06 May 2020 21:50:11 +0200

[Message part 1 (text/plain, inline)]

Hi!

Raghav Gururajan <raghavgururajan <at> disroot.org> writes:

> Here, I have attached another patch-set for modifying stuffs. :-)

I have added another set of nit-picks!  :-)

> From 30042d73a58f90971cd6c37bf56269bd3abb2533 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 2 May 2020 22:28:44 -0400
> Subject: [PATCH 08/14] gnu: girara: Update package definition.
>
> * gnu/packages/pwmt.scm (girara):
> [source]<origin>[method]: Changed from git-fetch to url-fetch; and
> remove file-name field.
> [arguments]<#:glib-or-gtk?>: New argument.
> [arguments]<#:configure-flags>[-Dnotify]: New flag.
> [native-inputs]<doxygen>: New input.
> [inputs]<glib,gtk+,json-c,libnotify,pango>: New inputs.
> [propagated-inputs]<gtk+>: Removed.
> [synopsis]: Updated.
> [description]: Updated.

I know it's a lot to ask, but it would be great if you could split this
up in multiple patches, one per logical change.  I.e. this one patch
would be better as a series like:

Raghav Gururajan (7):
  gnu: girara: Download tarball instead of git source.
  gnu: girara: Wrap with Glib variables.
  gnu: girara: Add notification support.
  gnu: girara: Build and install documentation.
  gnu: girara: Do not propagate GTK+.
  gnu: girara: Enable more features.
  gnu: girara: Update synopsis & description.

That makes it possible to revert some of these changes in case of
problems without undoing the whole thing, and also makes reviewing
easier.

I'm also skeptical about some of these (why is #:glib-or-gtk? necessary
for this library, why does GTK+ no longer need to be propagated, and
what are all those new inputs for?).  By lumping everything together
it's difficult to reason about these changes.

> From 7e3558dda412d33fffb7bb0668886f1ede3d14c8 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 2 May 2020 23:29:28 -0400
> Subject: [PATCH 09/14] gnu: zathura: Update package definition.
>
> * gnu/packages/pwmt.scm (zathura):
> [arguments]<#:glib-or-gtk?>: New argument.
> [native-inputs]<desktop-fileutils,doxygen,python-breathe,python-
> sphinx-rtd-theme>: New inputs.

Same here, what do these inputs do?

> [inputs]<appstream-glib,cairo,file,girara,glib,json-c,gtk+,libnotify,
> libseccomp>: New inputs.

And these?

> [propagated-inputs]<cairo,girara>: Removed.
> [synopsis]: Updated.
> [description]: Updated.

ISTM this could be split into at least four different patches.

> From 345a2b2ffc04c99fdfc3785ac6d19f053afd1b90 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Sat, 2 May 2020 23:42:49 -0400
> Subject: [PATCH 10/14] gnu: zathura-ps: Update package definition.
>
> * gnu/packages/pwmt.scm (zathura-ps):
> [arguments]<#:glib-or-gtk?>: New argument.

Why does this plugin package need #:glib-or-gtk?.

> [inputs]<cairo,girara,glib,gtk+,json-c,libnotify>: New inputs.

It's strange that all of these packages require almost the exact same
set of inputs.  Perhaps they should be propagated somewhere?

> [synopsis]: Updated.
> [description]: Updated.

This should also be a separate patch.

I think you catch my drift here, can you send an updated series?

[signature.asc (application/pgp-signature, inline)]

Message #47 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40994 <at> debbugs.gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>, Brice Waegeneire <brice <at> waegenei.re>
Subject: Updated patch-set.
Date: Thu, 7 May 2020 23:24:27 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-girara-Move-from-gtk.scm-to-pwmt.scm.patch (application/octet-stream, attachment)]

[0002-gnu-zathura-Move-from-pdf.scm-to-pwmt.scm.patch (application/octet-stream, attachment)]

[0003-gnu-zathura-ps-Move-from-pdf.scm-to-pwmt.scm.patch (application/octet-stream, attachment)]

[0004-gnu-zathura-pdf-poppler-Move-from-pdf.scm-to-pwmt.sc.patch (application/octet-stream, attachment)]

[0005-gnu-zathura-pdf-mupdf-Move-from-pdf.scm-to-pwmt.scm.patch (application/octet-stream, attachment)]

[0006-gnu-zathura-djvu-Move-from-pdf.scm-to-pwmt.scm.patch (application/octet-stream, attachment)]

[0007-gnu-zathura-cb-Move-from-pdf.scm-to-pwmt.scm.patch (application/octet-stream, attachment)]

[0008-gnu-girara-Download-tarball-instead-of-git-source.patch (application/octet-stream, attachment)]

[0009-gnu-girara-Rearrange-elements-of-package-definition.patch (application/octet-stream, attachment)]

[0010-gnu-girara-Update-package-definition.patch (application/octet-stream, attachment)]

[0011-gnu-zathura-Rearrange-elements-of-package-definition.patch (application/octet-stream, attachment)]

[0012-gnu-zathura-Update-package-definition.patch (application/octet-stream, attachment)]

[0013-gnu-zathura-ps-Rearrange-elements-of-package-definit.patch (application/octet-stream, attachment)]

[0014-gnu-zathura-ps-Update-package-definition.patch (application/octet-stream, attachment)]

[0015-gnu-zathura-pdf-poppler-Rearrange-elements-of-packag.patch (application/octet-stream, attachment)]

[0016-gnu-zathura-pdf-poppler-Update-package-definition.patch (application/octet-stream, attachment)]

[0017-gnu-zathura-pdf-mupdf-Rearrange-elements-of-package-.patch (application/octet-stream, attachment)]

[0018-gnu-zathura-pdf-mupdf-Update-package-definition.patch (application/octet-stream, attachment)]

[0019-gnu-zathura-djvu-Rearrange-elements-of-package-defin.patch (application/octet-stream, attachment)]

[0020-gnu-zathura-djvu-Update-package-definition.patch (application/octet-stream, attachment)]

[0021-gnu-zathura-cb-Rearrange-elements-of-package-definit.patch (application/octet-stream, attachment)]

[0022-gnu-zathura-cb-Update-package-definition.patch (application/octet-stream, attachment)]

Message #50 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40994 <at> debbugs.gnu.org, Brice Waegeneire <brice <at> waegenei.re>
Subject: Re: [bug#40994] patch#40994 Programs With Movie Titles (PWMT)
Date: Thu, 7 May 2020 23:28:17 -0400

Hi Marius!

> I'm not convinced that moving these packages are worth the effort,
> though I'm not opposed to it either.  What is the rationale?

The idea is to put together the packages of PWMT project. The concept is
similar to suckless.scm.

> For each patch, please include the copyright information for that
> package only.  I don't think all of these people worked on girara.

Yes, they have. I checked with git log. :-)

> Likewise for modules: gnome, web, xorg and xdisorg seems unused for
> girara. 
>
> And (guix download).
> 
> And gnu-build-system.
> 
> Also make sure that the files end with a newline, like all other files
> in Guix.

I have made these changes and sent updated patch to the thread.

Regards,
RG.

Message #53 received at 40994 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40994 <at> debbugs.gnu.org, Brice Waegeneire <brice <at> waegenei.re>
Subject: Re: [bug#40994] patch#40994 Programs With Movie Titles (PWMT)
Date: Thu, 7 May 2020 23:37:50 -0400

Hi Marius!

> I know it's a lot to ask, but it would be great if you could split this
> up in multiple patches, one per logical change.  I.e. this one patch
> would be better as a series like:
> 
> Raghav Gururajan (7):
>   gnu: girara: Download tarball instead of git source.
>   gnu: girara: Wrap with Glib variables.
>   gnu: girara: Add notification support.
>   gnu: girara: Build and install documentation.
>   gnu: girara: Do not propagate GTK+.
>   gnu: girara: Enable more features.
>   gnu: girara: Update synopsis & description.

Oh yeah, this is lot and I cannot do at this time. But I have sent updated
patch-set that splits some changes. :-)

Anyway, this suggestion is very useful, so that I can use it moving forward.

> I'm also skeptical about some of these (why is #:glib-or-gtk? necessary
> for this library, why does GTK+ no longer need to be propagated, and
> what are all those new inputs for?).  By lumping everything together
> it's difficult to reason about these changes.
>
> Same here, what do these inputs do?
> 
> > [inputs]<appstream-glib,cairo,file,girara,glib,json-c,gtk+,libnotify,  
> > libseccomp>: New inputs.  
> 
> And these?

I have used comments in the package definition. :-)

> Why does this plugin package need #:glib-or-gtk?.

That was a mistake. I removed it in the new patch-set.

> > [inputs]<cairo,girara,glib,gtk+,json-c,libnotify>: New inputs.  
> 
> It's strange that all of these packages require almost the exact same
> set of inputs.  Perhaps they should be propagated somewhere?

That's correct. cairo and girara are effect of removing propagation in zathura.
I think it is better not to propagate things, unless it is absolutely
necessary. Other inputs are simply required to generate 'cargs'.

> I think you catch my drift here, can you send an updated series?

I have sent an updated patch-set to the thread, with changes I could do at this
time. :-)

Regards,
RG.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.