GNU bug report logs - #40993
cuirass: Add build products download support.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <m.othacehe <at> gmail.com>

Date: Fri, 1 May 2020 08:56:02 UTC

Severity: normal

Done: Mathieu Othacehe <mathieu <at> meru.i-did-not-set--mail-host-address--so-tickle-me>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40993 <at> debbugs.gnu.org
Subject: [bug#40993] cuirass: Add build products download support.
Date: Wed, 03 Jun 2020 22:14:16 +0200

Hi!

Mathieu Othacehe <othacehe <at> gnu.org> skribis:

> From c99cc0314b98e349a577f38870d1271a3f1c3a54 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Date: Wed, 3 Jun 2020 13:41:30 +0200
> Subject: [PATCH] cuirass: Use sendfiles instead of raw copies.
>
> * src/cuirass/http.scm (respond-file): Send the file name as 'x-raw-file
> header argument, instead of the raw file content,
> (respond-gzipped-file): ditto. Also set 'content-disposition header.
> * src/web/server/fiberized.scm (strip-headers, with-content-length): New procedures,
> (client-loop): Check if 'x-raw-file is set. If it's the case, use sendfiles to
> send the given file. Otherwise, keep the existing behaviour and send directly
> the received bytevector.

If it works for you, LGTM!

Ludo’.
This bug report was last modified 4 years and 341 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.