GNU bug report logs - #40980
gnu: xfe: Fix configuration and icons.

Previous Next

Full log

Message #14 received at 40980 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40980 <at> debbugs.gnu.org
Subject: Re: [bug#40980] gnu: xfe: Fix configuration and icons. (v3)
Date: Fri, 1 May 2020 10:41:29 -0400

[Message part 1 (text/plain, inline)]

Hi Danny!

> > * gnu/packages/disk.scm (xfe): Fix configuration and icons.  
> 
> Please mention the phases and arguments you changed.
> 
> >       (origin
> >         (method url-fetch)
> >         (uri
> > -        (string-append "https://sourceforge.net/projects/xfe/files/xfe/"
> > -                       version
> > -                       "/xfe-" version ".tar.gz"))
> > +        (string-append "https://sourceforge.net/projects/" name "/files/"
> > name
> > +                       "/" version "/" name "-" version ".tar.gz"))  
> 
> Please don't do that without a good reason because it makes us unable to
> rename our package later.
> 
> > -         (add-after 'unpack 'patch-xferc-path
> > +         (add-after 'unpack 'patch-xfe-paths  
> 
> Please mention this in the commit log.
> 
> > -       #:make-flags
> > -       (let ((out (assoc-ref %outputs "out")))
> > -         (list (string-append "BASH_COMPLETION_DIR=" out
> > -                              "/share/bash-completion/completions")))))  
> 
> Please mention the removal of make-flags in the commit log.

Please find the revised patch attached with this email.

Regards,
RG.

[0001-gnu-xfe-Fix-configuration-and-icons.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.