GNU bug report logs - #40980
gnu: xfe: Fix configuration and icons.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40980 in the body.
You can then email your comments to 40980 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: xfe: Fix configuration and icons.
Date: Thu, 30 Apr 2020 07:29:30 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-xfe-Fix-configuration-and-icons.patch (text/x-patch, attachment)]

Message #8 received at 40980 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 40980 <at> debbugs.gnu.org
Subject: gnu: xfe: Fix configuration and icons. (v2)
Date: Fri, 1 May 2020 03:47:03 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-xfe-Fix-configuration-and-icons.patch (text/x-patch, attachment)]

Message #11 received at 40980 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40980 <at> debbugs.gnu.org
Subject: Re: [bug#40980] gnu: xfe: Fix configuration and icons. (v2)
Date: Fri, 1 May 2020 13:55:54 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

On Fri, 1 May 2020 03:47:03 -0400
Raghav Gururajan <raghavgururajan <at> disroot.org> wrote:

> * gnu/packages/disk.scm (xfe): Fix configuration and icons.

Please mention the phases and arguments you changed.

>       (origin
>         (method url-fetch)
>         (uri
> -        (string-append "https://sourceforge.net/projects/xfe/files/xfe/"
> -                       version
> -                       "/xfe-" version ".tar.gz"))
> +        (string-append "https://sourceforge.net/projects/" name "/files/" name
> +                       "/" version "/" name "-" version ".tar.gz"))

Please don't do that without a good reason because it makes us unable to rename
our package later.

> -         (add-after 'unpack 'patch-xferc-path
> +         (add-after 'unpack 'patch-xfe-paths

Please mention this in the commit log.

> -       #:make-flags
> -       (let ((out (assoc-ref %outputs "out")))
> -         (list (string-append "BASH_COMPLETION_DIR=" out
> -                              "/share/bash-completion/completions")))))

Please mention the removal of make-flags in the commit log.

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 40980 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40980 <at> debbugs.gnu.org
Subject: Re: [bug#40980] gnu: xfe: Fix configuration and icons. (v3)
Date: Fri, 1 May 2020 10:41:29 -0400

[Message part 1 (text/plain, inline)]

Hi Danny!

> > * gnu/packages/disk.scm (xfe): Fix configuration and icons.  
> 
> Please mention the phases and arguments you changed.
> 
> >       (origin
> >         (method url-fetch)
> >         (uri
> > -        (string-append "https://sourceforge.net/projects/xfe/files/xfe/"
> > -                       version
> > -                       "/xfe-" version ".tar.gz"))
> > +        (string-append "https://sourceforge.net/projects/" name "/files/"
> > name
> > +                       "/" version "/" name "-" version ".tar.gz"))  
> 
> Please don't do that without a good reason because it makes us unable to
> rename our package later.
> 
> > -         (add-after 'unpack 'patch-xferc-path
> > +         (add-after 'unpack 'patch-xfe-paths  
> 
> Please mention this in the commit log.
> 
> > -       #:make-flags
> > -       (let ((out (assoc-ref %outputs "out")))
> > -         (list (string-append "BASH_COMPLETION_DIR=" out
> > -                              "/share/bash-completion/completions")))))  
> 
> Please mention the removal of make-flags in the commit log.

Please find the revised patch attached with this email.

Regards,
RG.

[0001-gnu-xfe-Fix-configuration-and-icons.patch (text/x-patch, attachment)]

Message #17 received at 40980 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40980 <at> debbugs.gnu.org
Subject: Re: [bug#40980] gnu: xfe: Fix configuration and icons. (v3)
Date: Fri, 1 May 2020 16:54:47 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

please use our machine-readable metadata commit log convention instead of using
free text.

See our git log.

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 40980 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 40980 <at> debbugs.gnu.org
Subject: Re: [bug#40980] gnu: xfe: Fix configuration and icons. (v4)
Date: Fri, 1 May 2020 12:45:03 -0400

[Message part 1 (text/plain, inline)]

Hi Danny!

> please use our machine-readable metadata commit log convention instead of
> using free text.
> 
> See our git log.

Sorry about that. I just saw your modified commit message in previous commits.

Please find the revised patch attached with this email.

Regards,
RG.

[0001-gnu-xfe-Fix-configuration-and-icons.patch (text/x-patch, attachment)]

Message #25 received at 40980-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40980-done <at> debbugs.gnu.org
Subject: Re: [bug#40980] gnu: xfe: Fix configuration and icons. (v4)
Date: Fri, 1 May 2020 19:21:06 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

thanks!

Pushed to guix master as commit 7dfc7c5398c16bdf27acf260c71f905d13bb3a9c
with tiny changes.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.