GNU bug report logs - #40980
gnu: xfe: Fix configuration and icons.

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40980 <at> debbugs.gnu.org
Subject: [bug#40980] gnu: xfe: Fix configuration and icons. (v2)
Date: Fri, 1 May 2020 13:55:54 +0200

[Message part 1 (text/plain, inline)]

Hi Raghav,

On Fri, 1 May 2020 03:47:03 -0400
Raghav Gururajan <raghavgururajan <at> disroot.org> wrote:

> * gnu/packages/disk.scm (xfe): Fix configuration and icons.

Please mention the phases and arguments you changed.

>       (origin
>         (method url-fetch)
>         (uri
> -        (string-append "https://sourceforge.net/projects/xfe/files/xfe/"
> -                       version
> -                       "/xfe-" version ".tar.gz"))
> +        (string-append "https://sourceforge.net/projects/" name "/files/" name
> +                       "/" version "/" name "-" version ".tar.gz"))

Please don't do that without a good reason because it makes us unable to rename
our package later.

> -         (add-after 'unpack 'patch-xferc-path
> +         (add-after 'unpack 'patch-xfe-paths

Please mention this in the commit log.

> -       #:make-flags
> -       (let ((out (assoc-ref %outputs "out")))
> -         (list (string-append "BASH_COMPLETION_DIR=" out
> -                              "/share/bash-completion/completions")))))

Please mention the removal of make-flags in the commit log.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.