GNU bug report logs - #40931
[PATCH] gnu: add j4-dmenu-desktop

Previous Next

Full log

Message #22 received at 40931-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alex McGrath <amk <at> amk.ie>, 40931 <40931-done <at> debbugs.gnu.org>
Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop
Date: Mon, 04 May 2020 16:33:05 +0200

[Message part 1 (text/plain, inline)]

"Alex McGrath" <amk <at> amk.ie> writes:

> Howdy,
>
> I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result

Excellent, LGTM!

I've applied the patch with minor adjustments (removed redundant
#:tests? #t, and formatted description with @file and @command markup
where appropriate).

Pushed in c65e243463c704698288bad787cd6f5292280bba, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.