GNU bug report logs - #40931
[PATCH] gnu: add j4-dmenu-desktop

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40931 in the body.
You can then email your comments to 40931 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex McGrath <amk <at> amk.ie>
To: guix-patches <at> gnu.org
Cc: Alex McGrath <amk <at> amk.ie>
Subject: [PATCH] gnu: add j4-dmenu-desktop
Date: Tue, 28 Apr 2020 11:37:05 +0100

---
 gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index bc2c9c4622..02997dcbf1 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -35,6 +35,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 Damien Cassou <damien <at> cassou.me>
 ;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
+;;; Copyright © 2020 Alex McGrath <amk <at> amk.ie>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2286,3 +2287,25 @@ to find all available clips and launches @command{dmenu} (or @command{rofi},
 depending on the value of @code{CM_LAUNCHER}) to let the user select a clip.
 After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.")
       (license license:public-domain))))
+
+(define-public j4-dmenu-desktop
+  (package
+    (name "j4-dmenu-desktop")
+    (version "2.17")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/enkore/j4-dmenu-desktop.git")
+                    (commit (string-append "r" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off")
+       #:tests? #f)) ;; tests fetch an external git repo
+    (synopsis "A fast desktop menu")
+    (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.")
+    (home-page "https://github.com/enkore/j4-dmenu-desktop")
+    (license license:gpl3+)))
-- 
2.26.1

Message #8 received at 40931 <at> debbugs.gnu.org (full text, mbox):

From: Alex McGrath <amk <at> amk.ie>
To: 40931 <at> debbugs.gnu.org
Cc: Alex McGrath <amk <at> amk.ie>
Subject: [PATCH v2] gnu: add j4-dmenu-desktop
Date: Wed, 29 Apr 2020 08:52:33 +0100

* gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable.

 gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index bc2c9c4622..02997dcbf1 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -35,6 +35,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 Damien Cassou <damien <at> cassou.me>
 ;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
+;;; Copyright © 2020 Alex McGrath <amk <at> amk.ie>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2286,3 +2287,25 @@ to find all available clips and launches @command{dmenu} (or @command{rofi},
 depending on the value of @code{CM_LAUNCHER}) to let the user select a clip.
 After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.")
       (license license:public-domain))))
+
+(define-public j4-dmenu-desktop
+  (package
+    (name "j4-dmenu-desktop")
+    (version "2.17")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/enkore/j4-dmenu-desktop.git")
+                    (commit (string-append "r" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off")
+       #:tests? #f)) ;; tests fetch an external git repo
+    (synopsis "A fast desktop menu")
+    (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.")
+    (home-page "https://github.com/enkore/j4-dmenu-desktop")
+    (license license:gpl3+)))
-- 
2.26.1

Message #11 received at 40931 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alex McGrath <amk <at> amk.ie>, 40931 <at> debbugs.gnu.org
Cc: Alex McGrath <amk <at> amk.ie>
Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop
Date: Sat, 02 May 2020 16:18:17 +0200

[Message part 1 (text/plain, inline)]

Alex McGrath <amk <at> amk.ie> writes:

> * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable.

Thanks!  Unfortunately the patch no longer applies, can you rebase it on
the current master branch?

[...]

> +(define-public j4-dmenu-desktop
> +  (package
> +    (name "j4-dmenu-desktop")
> +    (version "2.17")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/enkore/j4-dmenu-desktop.git")
> +                    (commit (string-append "r" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off")

Note that cmake-build-system exposes #:build-type, so you don't have to
pass "-DCMAKE_BUILD_TYPE".  By default it uses RelWithDebugInfo which is
better because it adds debug information.  There are cases where we
want "Release" instead (size or performance concerns), but it probably
is fine for this package?

> +       #:tests? #f)) ;; tests fetch an external git repo

Is it possible to provide this repo as a native-input?  See e.g. 'ghc'.
Don't stress it if it's not possible, though.

> +    (synopsis "A fast desktop menu")

Just "Fast desktop menu" ('./pre-inst-env guix lint j4-dmenu-desktop'
should warn about this).

> +    (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.")

Use two spaces between sentences, and try to wrap lines at ~78
characters.  'guix lint' will warn about this, too.  :-)

Can you send an updated patch?  Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 40931 <at> debbugs.gnu.org (full text, mbox):

From: Alex McGrath <amk <at> amk.ie>
To: 40931 <at> debbugs.gnu.org
Cc: Alex McGrath <amk <at> amk.ie>
Subject: [PATCH v3] gnu: add j4-dmenu-desktop
Date: Sat,  2 May 2020 18:51:56 +0100

* gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable.
---
 gnu/packages/xdisorg.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index df61a95cbb..99b3f765d2 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2020 Damien Cassou <damien <at> cassou.me>
 ;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
 ;;; Copyright © 2020 Boris A. Dekshteyn <boris.dekshteyn <at> gmail.com>
+;;; Copyright © 2020 Alex McGrath <amk <at> amk.ie>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2324,3 +2325,34 @@ some kind of chat (in native language).
 @command{kbdd} also supports D-Bus signals, which makes it possible to
 create layout indicator widgets.")
     (license license:bsd-2)))
+
+(define-public j4-dmenu-desktop
+  (package
+    (name "j4-dmenu-desktop")
+    (version "2.17")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/enkore/j4-dmenu-desktop.git")
+                    (commit (string-append "r" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("catch2" ,catch-framework2)))
+    (arguments
+     `(#:configure-flags '("-DWITH_GIT_CATCH=off")
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "./j4-dmenu-tests" "exclude:SearchPath/XDG_DATA_HOME"))))
+       #:tests? #t))
+    (synopsis "Fast desktop menu")
+    (description  "j4-dmenu-desktop is a replacement for
+i3-dmenu-desktop.  It's purpose is to find desktop files and offer you a menu
+to start an application using dmenu.")
+    (home-page "https://github.com/enkore/j4-dmenu-desktop")
+    (license license:gpl3+)))
-- 
2.26.2

Message #17 received at 40931 <at> debbugs.gnu.org (full text, mbox):

From: "Alex McGrath" <amk <at> amk.ie>
To: "40931" <40931 <at> debbugs.gnu.org>
Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop
Date: Sat, 02 May 2020 18:57:51 +0100 (IST)

Howdy,

I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result

Thanks for the review!
Alex

Message #22 received at 40931-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alex McGrath <amk <at> amk.ie>, 40931 <40931-done <at> debbugs.gnu.org>
Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop
Date: Mon, 04 May 2020 16:33:05 +0200

[Message part 1 (text/plain, inline)]

"Alex McGrath" <amk <at> amk.ie> writes:

> Howdy,
>
> I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result

Excellent, LGTM!

I've applied the patch with minor adjustments (removed redundant
#:tests? #t, and formatted description with @file and @command markup
where appropriate).

Pushed in c65e243463c704698288bad787cd6f5292280bba, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.