GNU bug report logs - #40931
[PATCH] gnu: add j4-dmenu-desktop

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40931: closed ([PATCH] gnu: add j4-dmenu-desktop)
Date: Mon, 04 May 2020 14:34:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 04 May 2020 16:33:05 +0200
with message-id <87pnbj22ji.fsf <at> devup.no>
and subject line Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop
has caused the debbugs.gnu.org bug report #40931,
regarding [PATCH] gnu: add j4-dmenu-desktop
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40931: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40931
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex McGrath <amk <at> amk.ie>
To: guix-patches <at> gnu.org
Cc: Alex McGrath <amk <at> amk.ie>
Subject: [PATCH] gnu: add j4-dmenu-desktop
Date: Tue, 28 Apr 2020 11:37:05 +0100

---
 gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index bc2c9c4622..02997dcbf1 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -35,6 +35,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 Damien Cassou <damien <at> cassou.me>
 ;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
+;;; Copyright © 2020 Alex McGrath <amk <at> amk.ie>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2286,3 +2287,25 @@ to find all available clips and launches @command{dmenu} (or @command{rofi},
 depending on the value of @code{CM_LAUNCHER}) to let the user select a clip.
 After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.")
       (license license:public-domain))))
+
+(define-public j4-dmenu-desktop
+  (package
+    (name "j4-dmenu-desktop")
+    (version "2.17")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/enkore/j4-dmenu-desktop.git")
+                    (commit (string-append "r" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off")
+       #:tests? #f)) ;; tests fetch an external git repo
+    (synopsis "A fast desktop menu")
+    (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.")
+    (home-page "https://github.com/enkore/j4-dmenu-desktop")
+    (license license:gpl3+)))
-- 
2.26.1

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alex McGrath <amk <at> amk.ie>, 40931 <40931-done <at> debbugs.gnu.org>
Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop
Date: Mon, 04 May 2020 16:33:05 +0200

[Message part 4 (text/plain, inline)]

"Alex McGrath" <amk <at> amk.ie> writes:

> Howdy,
>
> I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result

Excellent, LGTM!

I've applied the patch with minor adjustments (removed redundant
#:tests? #t, and formatted description with @file and @command markup
where appropriate).

Pushed in c65e243463c704698288bad787cd6f5292280bba, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.