GNU bug report logs - #40902
[PATCH] gnu: Add edid-decode.

Previous Next

Full log

Message #14 received at 40902 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 40902 <at> debbugs.gnu.org
Subject: Re: [bug#40902] [PATCH] gnu: Add edid-decode.
Date: Tue, 28 Apr 2020 09:54:06 +0000

Hello Mathieu,

Thank you for taking the time to review this patch.

On 2020-04-28 07:46, Mathieu Othacehe wrote:
> Hello Brice,
> 
> You can add your copyright.

I already added it in #40607[0], an unmerged patch adding usbguard.

>> +(define-public edid-decode
>> +  (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; 
>> 2020-04-22
>> +        (revision "1"))
>> +   (package
>> +     (name "edid-decode")
>> +     (version (git-version "0.0.0" revision commit))
> 
> The indentation of the block seems wrong.

You are correct, “guix lint” didn't mentioned it though. Fixed in v2.

>> +     (source
>> +      (origin
>> +        (method git-fetch)
>> +        (file-name (git-file-name name version))
>> +        (uri (git-reference
>> +              (url "git://linuxtv.org/edid-decode.git")
>> +              (commit commit)))
>> +        (sha256
>> +         (base32 
>> "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah"))))
>> +     (build-system gnu-build-system)
>> +     (arguments
>> +      `(#:tests? #f                     ; No test suite
>> +        #:make-flags
>> +        (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> +              "bindir=/bin" "mandir=/share/man")
>> +        #:phases
>> +        (modify-phases %standard-phases
>> +          (delete 'configure))))
> 
> When cross-compiling, a native binary is produced. This is because CXX
> is set to 'g++' I guess. You need to do something similar to what is
> done in the 'maradns' package.

I never thought of testing that, I should start doing it. Fixed in v2.

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40607#28

- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.