GNU bug report logs - #40901
gnu: ktsuss: Fix paths.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40901 in the body.
You can then email your comments to 40901 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Jan Nieuwenhuizen <janneke <at> gnu.org>
Subject: gnu: ktsuss: Fix paths.
Date: Mon, 27 Apr 2020 09:37:02 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-ktsuss-Fix-paths.patch (text/x-patch, attachment)]

Message #8 received at 40901 <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40901 <at> debbugs.gnu.org
Subject: Re: [bug#40901] gnu: ktsuss: Fix paths.
Date: Mon, 27 Apr 2020 18:21:31 +0200

Raghav Gururajan writes:

Hello Raghav,

> From ecdb9f73f2aa9854f03ace199fcc4c4547a2be49 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Mon, 27 Apr 2020 09:32:43 -0400
> Subject: [PATCH] gnu: ktsuss: Fix paths.
>
> * gnu/packages/admin.scm (ktsuss): Fix paths.

I changed the commit message to

--8<---------------cut here---------------start------------->8---
gnu: ktsuss: Use setuid "su" and "sudo" commands.

This has ktsudo actually gain root access.

* gnu/packages/admin.scm (ktsuss)[arguments]: Instead of <sudo>/bin/{su,sudo}
file names, use the setuid' verrsions.
--8<---------------cut here---------------end--------------->8---

When there is a fix being made, a short explanation is nice to have.
What was wrong that the file name were changed, what was fixed?

Also, we are (mainly) fixing the file names of SU and SUDO, not PATHs.

> -         (add-after 'unpack 'patch-sudo-path
> -           (lambda* (#:key inputs #:allow-other-keys)
> +         (add-after 'unpack 'patch-paths

Renamed to 'patch-file-names'

> +           (lambda* (#:key inputs outputs #:allow-other-keys)

Parameters inputs and outputs are both not used; I changed this to

+           (lambda _

> +             (substitute* "src/ktsuss.c"
> +               (("/usr/sbin:/usr/local/sbin:/sbin")
> +                "~/.guix-profile/sbin"))

No way!  :-)

I removed/did not apply this change.

>               (substitute* "configure.ac"
> +               (("supath=`which su 2>/dev/null`")
> +                "supath=/run/setuid-programs/su")
>                 (("sudopath=`which sudo 2>/dev/null`")
> -                (string-append "sudopath="
> -                               (string-append (assoc-ref inputs "sudo")
> -                                              "/bin/sudo"))))
> +                "sudopath=/run/setuid-programs/sudo"))

LGTM!

Can you please remember to test a program before submitting it?  And I
mean not only check if "it runs", but also if it is actually useful?

Pushed to master with these changes.

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Message #11 received at 40901 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 40901 <at> debbugs.gnu.org
Subject: Re: [bug#40901] gnu: ktsuss: Fix paths.
Date: Tue, 28 Apr 2020 03:43:14 -0400

[Message part 1 (text/plain, inline)]

Hello Jan!

> Can you please remember to test a program before submitting it?  And I
> mean not only check if "it runs", but also if it is actually useful?

Sorry. I have attached a patch with this email to make ktsuss work correctly.

This, along with #40922, allows me to fix SpaceFM.

Regards,
RG.

[0002-gnu-ktsuss-Disable-sudo.patch (text/x-patch, attachment)]

Message #14 received at 40901 <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40901 <at> debbugs.gnu.org
Subject: Re: [bug#40901] gnu: ktsuss: Fix paths.
Date: Tue, 28 Apr 2020 19:13:07 +0200

Raghav Gururajan writes:

Hello Raghav,

>> Can you please remember to test a program before submitting it?  And I
>> mean not only check if "it runs", but also if it is actually useful?
>
> Sorry. I have attached a patch with this email to make ktsuss work
> correctly.

Hmm, I experienced no problem when I tested it.  What did you observe
(see my question below).

> From a1d5a14bb634fe52201fdde9ffbd3e385b89d234 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan <at> disroot.org>
> Date: Tue, 28 Apr 2020 03:34:05 -0400
> Subject: [PATCH 2/2] gnu: ktsuss: Disable sudo.
>
> * gnu/packages/admin.scm (ktsuss): Disable sudo.
>
> Disabled sudo-backend as there is an unknown bug in upstream.
> Ktsuss now fall-back to using su-backend, which works correctly.

Having a like this is great.  Two remarks

  * please move it above the "* gnu/packages/admin" line
  * it would be great if you can add link to the ktsuss bug tracer about
    this "unknown" bug

Without any indication about what the bug is or how it can be
reproduced, it becomes hard to remove this workaround.

Other than that: LGTM.

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Message #17 received at 40901 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 40901 <at> debbugs.gnu.org
Subject: Re: [bug#40901] gnu: ktsuss: Fix paths.
Date: Thu, 30 Apr 2020 04:39:18 -0400

[Message part 1 (text/plain, inline)]

Hi Jan!
> Having a like this is great.  Two remarks
> 
>   * please move it above the "* gnu/packages/admin" line

Done!

>   * it would be great if you can add link to the ktsuss bug tracer about
>     this "unknown" bug

It is not reported yet. I could report it, but I am not sure how to debug
deeper to pin-point the exact part of the sudo-backend that has the bug. So I
have changed commit-message to fit situation.

Please find the revised patch attached with this email.

Regards,
RG.

[0001-gnu-ktsuss-Revert-back-to-su-from-sudo.patch (text/x-patch, attachment)]

Message #20 received at 40901 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 40901 <at> debbugs.gnu.org
Subject: Re: [bug#40901] gnu: ktsuss: Fix paths.
Date: Thu, 30 Apr 2020 09:54:07 -0400

Hi Jan!

Please ignore #40901. Let's leave it closed.

Regards,
RG.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.