GNU bug report logs - #40879
[PATCH] gnu: linux-boot: Allow to mount the root file system via nfs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40879: closed ([PATCH] gnu: linux-boot: Allow to mount the
 root file system via nfs)
Date: Sat, 02 May 2020 14:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 02 May 2020 16:22:19 +0200
with message-id <87wo5u5sdg.fsf <at> gnu.org>
and subject line Re: [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
has caused the debbugs.gnu.org bug report #40879,
regarding [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40879: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40879
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan <stefan-guix <at> vodafonemail.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
Date: Sun, 26 Apr 2020 21:21:38 +0200

* gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source
and avoid to call 'canonicalize-device-spec' for it.
---
 gnu/build/linux-boot.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm
index 4fb711b8f2..05e833c0c6 100644
--- a/gnu/build/linux-boot.scm
+++ b/gnu/build/linux-boot.scm
@@ -534,10 +534,13 @@ upon error."
             ;; The "--root=SPEC" kernel command-line option always provides a
             ;; string, but the string can represent a device, a UUID, or a
             ;; label.  So check for all three.
-            (let ((root (cond ((string-prefix? "/" root) root)
-                              ((uuid root) => identity)
-                              (else (file-system-label root)))))
-              (mount-root-file-system (canonicalize-device-spec root)
+            (let ((device-spec (cond ((string-prefix? "/" root) root)
+                                     ((uuid root) => identity)
+                                     ((string-contains root ":/") #f) ; nfs
+                                     (else (file-system-label root)))))
+              (mount-root-file-system (if device-spec
+                                          (canonicalize-device-spec device-spec)
+                                          root)
                                       root-fs-type
                                       #:volatile-root? volatile-root?
                                       #:flags root-fs-flags
-- 
2.26.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Stefan <stefan-guix <at> vodafonemail.de>
Cc: 40879-done <at> debbugs.gnu.org
Subject: Re: [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file
 system via nfs
Date: Sat, 02 May 2020 16:22:19 +0200

Hi Stefan,

Stefan <stefan-guix <at> vodafonemail.de> skribis:

> * gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source
> and avoid to call 'canonicalize-device-spec' for it.

I slightly tweaked the subject line and applied, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.