GNU bug report logs - #40879
[PATCH] gnu: linux-boot: Allow to mount the root file system via nfs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40879 in the body.
You can then email your comments to 40879 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan <stefan-guix <at> vodafonemail.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
Date: Sun, 26 Apr 2020 21:21:38 +0200

* gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source
and avoid to call 'canonicalize-device-spec' for it.
---
 gnu/build/linux-boot.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm
index 4fb711b8f2..05e833c0c6 100644
--- a/gnu/build/linux-boot.scm
+++ b/gnu/build/linux-boot.scm
@@ -534,10 +534,13 @@ upon error."
             ;; The "--root=SPEC" kernel command-line option always provides a
             ;; string, but the string can represent a device, a UUID, or a
             ;; label.  So check for all three.
-            (let ((root (cond ((string-prefix? "/" root) root)
-                              ((uuid root) => identity)
-                              (else (file-system-label root)))))
-              (mount-root-file-system (canonicalize-device-spec root)
+            (let ((device-spec (cond ((string-prefix? "/" root) root)
+                                     ((uuid root) => identity)
+                                     ((string-contains root ":/") #f) ; nfs
+                                     (else (file-system-label root)))))
+              (mount-root-file-system (if device-spec
+                                          (canonicalize-device-spec device-spec)
+                                          root)
                                       root-fs-type
                                       #:volatile-root? volatile-root?
                                       #:flags root-fs-flags
-- 
2.26.0

Message #10 received at 40879-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Stefan <stefan-guix <at> vodafonemail.de>
Cc: 40879-done <at> debbugs.gnu.org
Subject: Re: [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file
 system via nfs
Date: Sat, 02 May 2020 16:22:19 +0200

Hi Stefan,

Stefan <stefan-guix <at> vodafonemail.de> skribis:

> * gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source
> and avoid to call 'canonicalize-device-spec' for it.

I slightly tweaked the subject line and applied, thank you!

Ludo’.

Message #13 received at 40879-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ludovic Courtès <ludo <at> gnu.org>, Stefan
 <stefan-guix <at> vodafonemail.de>
Cc: 40879-done <at> debbugs.gnu.org
Subject: Re: bug#40879: [PATCH] gnu: linux-boot: Allow to mount the root
 file system via nfs
Date: Sun, 3 May 2020 00:19:16 +0200

[Message part 1 (text/plain, inline)]

--- a/gnu/build/linux-boot.scm
+++ b/gnu/build/linux-boot.scm
@@ -534,10 +534,13 @@ upon error."
             ;; The "--root=SPEC" kernel command-line option always provides a
             ;; string, but the string can represent a device, a UUID, or a
             ;; label.  So check for all three.

Nitpick: Comment above it is now outdated ;)

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 40879-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>, Ludovic Courtès <ludo <at> gnu.org>, Stefan <stefan-guix <at> vodafonemail.de>
Cc: 40879-done <at> debbugs.gnu.org
Subject: Re: [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file
 system via nfs
Date: Mon, 04 May 2020 16:11:11 +0200

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> --- a/gnu/build/linux-boot.scm
> +++ b/gnu/build/linux-boot.scm
> @@ -534,10 +534,13 @@ upon error."
>              ;; The "--root=SPEC" kernel command-line option always provides a
>              ;; string, but the string can represent a device, a UUID, or a
>              ;; label.  So check for all three.
>
> Nitpick: Comment above it is now outdated ;)

Can you update it?  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.