GNU bug report logs - #40712
gnu: Add midori.

Previous Next

Full log

Message #20 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40712 <at> debbugs.gnu.org, pacoon <at> protonmail.com
Subject: Re: [bug#40712] gnu: Add midori. (v3)
Date: Sun, 19 Apr 2020 09:42:13 -0400

[Message part 1 (text/plain, inline)]

Hi Mathieu!

> >>> Thanks for your patch! This is a duplicate of
> >>> https://lists.gnu.org/archive/html/guix-patches/2020-03/msg00729.html.  
> >> 
> >> Oops! I did not know that. Sorry!
> >>   
> >>> Like with Rene patch HTTPS didn't work for me. However when adding:
> >>> 
> >>> --8<---------------cut here---------------start------------->8---
> >>> ("glib-networking" ,glib-networking)
> >>> --8<---------------cut here---------------end--------------->8---
> >>> 
> >>> to inputs, yours work. Not sure how to proceed here.  
> >> 
> >> It's because I have used glib phases.  
> > 
> > Along with 'glib-networking', could you also add the following please?
> > 
> > (add-after 'install 'wrap-typelib
> > (lambda* (#:key outputs #:allow-other-keys)
> > (let ((prog (string-append (assoc-ref outputs "out")
> > "/bin/midori")))
> > (wrap-program prog
> > `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))
> > #t)))
> > 
> > Sorry, I am at work now and do not have my machine.  
> 
> Looks like typelib wrap not required. Please find the revised oatch attached
> with this email.

Here is the final revised patch. This works perfectly. I tried `./pre-inst-env
guix environment --ad-hoc midori --pure` and `midori`.

Regards,
RG

[0001-gnu-Add-midori.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.