GNU bug report logs - #40712
gnu: Add midori.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40712 in the body.
You can then email your comments to 40712 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: Add midori.
Date: Sun, 19 Apr 2020 10:04:48 +0000

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-midori.patch (application/octet-stream, attachment)]

Message #8 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 40712 <at> debbugs.gnu.org, pacoon <at> protonmail.com
Subject: Re: [bug#40712] gnu: Add midori.
Date: Sun, 19 Apr 2020 12:34:55 +0200

Hello Raghav,

Thanks for your patch! This is a duplicate of
https://lists.gnu.org/archive/html/guix-patches/2020-03/msg00729.html.

Like with Rene patch HTTPS didn't work for me. However when adding:

--8<---------------cut here---------------start------------->8---
       ("glib-networking" ,glib-networking)
--8<---------------cut here---------------end--------------->8---

to inputs, yours work. Not sure how to proceed here.

Rene, would it be ok for your you if we merge Raghav patch?

Thanks,

Mathieu

Message #11 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40712 <at> debbugs.gnu.org, pacoon <at> protonmail.com
Subject: Re: [bug#40712] gnu: Add midori.
Date: Sun, 19 Apr 2020 10:40:51 +0000

Hi Mathieu!

> Thanks for your patch! This is a duplicate of
> https://lists.gnu.org/archive/html/guix-patches/2020-03/msg00729.html.

Oops! I did not know that. Sorry!

> Like with Rene patch HTTPS didn't work for me. However when adding:
> 
> --8<---------------cut here---------------start------------->8---
> ("glib-networking" ,glib-networking)
> --8<---------------cut here---------------end--------------->8---
> 
> to inputs, yours work. Not sure how to proceed here.

It's because I have used glib phases.

Regards,
RG.

Message #14 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40712 <at> debbugs.gnu.org, pacoon <at> protonmail.com
Subject: Re: [bug#40712] gnu: Add midori.
Date: Sun, 19 Apr 2020 10:49:15 +0000

Hi Mathieu!

>> Thanks for your patch! This is a duplicate of
>> https://lists.gnu.org/archive/html/guix-patches/2020-03/msg00729.html.
> 
> Oops! I did not know that. Sorry!
> 
>> Like with Rene patch HTTPS didn't work for me. However when adding:
>> 
>> --8<---------------cut here---------------start------------->8---
>> ("glib-networking" ,glib-networking)
>> --8<---------------cut here---------------end--------------->8---
>> 
>> to inputs, yours work. Not sure how to proceed here.
> 
> It's because I have used glib phases.

Along with 'glib-networking', could you also add the following please?

         (add-after 'install 'wrap-typelib
           (lambda* (#:key outputs #:allow-other-keys)
             (let ((prog (string-append (assoc-ref outputs "out")
                                        "/bin/midori")))
               (wrap-program prog
                 `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))
               #t)))

Sorry, I am at work now and do not have my machine.

Regards,
RG.

Message #17 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40712 <at> debbugs.gnu.org, pacoon <at> protonmail.com
Subject: Re: [bug#40712] gnu: Add midori. (v2)
Date: Sun, 19 Apr 2020 11:12:03 +0000

[Message part 1 (text/plain, inline)]

Hi Mathieu!

>>> Thanks for your patch! This is a duplicate of
>>> https://lists.gnu.org/archive/html/guix-patches/2020-03/msg00729.html.
>> 
>> Oops! I did not know that. Sorry!
>> 
>>> Like with Rene patch HTTPS didn't work for me. However when adding:
>>> 
>>> --8<---------------cut here---------------start------------->8---
>>> ("glib-networking" ,glib-networking)
>>> --8<---------------cut here---------------end--------------->8---
>>> 
>>> to inputs, yours work. Not sure how to proceed here.
>> 
>> It's because I have used glib phases.
> 
> Along with 'glib-networking', could you also add the following please?
> 
> (add-after 'install 'wrap-typelib
> (lambda* (#:key outputs #:allow-other-keys)
> (let ((prog (string-append (assoc-ref outputs "out")
> "/bin/midori")))
> (wrap-program prog
> `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))
> #t)))
> 
> Sorry, I am at work now and do not have my machine.

Looks like typelib wrap not required. Please find the revised oatch attached with this email.

Regards,
RG.

[0001-gnu-Add-midori.patch (application/octet-stream, attachment)]

Message #20 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 40712 <at> debbugs.gnu.org, pacoon <at> protonmail.com
Subject: Re: [bug#40712] gnu: Add midori. (v3)
Date: Sun, 19 Apr 2020 09:42:13 -0400

[Message part 1 (text/plain, inline)]

Hi Mathieu!

> >>> Thanks for your patch! This is a duplicate of
> >>> https://lists.gnu.org/archive/html/guix-patches/2020-03/msg00729.html.  
> >> 
> >> Oops! I did not know that. Sorry!
> >>   
> >>> Like with Rene patch HTTPS didn't work for me. However when adding:
> >>> 
> >>> --8<---------------cut here---------------start------------->8---
> >>> ("glib-networking" ,glib-networking)
> >>> --8<---------------cut here---------------end--------------->8---
> >>> 
> >>> to inputs, yours work. Not sure how to proceed here.  
> >> 
> >> It's because I have used glib phases.  
> > 
> > Along with 'glib-networking', could you also add the following please?
> > 
> > (add-after 'install 'wrap-typelib
> > (lambda* (#:key outputs #:allow-other-keys)
> > (let ((prog (string-append (assoc-ref outputs "out")
> > "/bin/midori")))
> > (wrap-program prog
> > `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))
> > #t)))
> > 
> > Sorry, I am at work now and do not have my machine.  
> 
> Looks like typelib wrap not required. Please find the revised oatch attached
> with this email.

Here is the final revised patch. This works perfectly. I tried `./pre-inst-env
guix environment --ad-hoc midori --pure` and `midori`.

Regards,
RG

[0001-gnu-Add-midori.patch (text/x-patch, attachment)]

Message #23 received at 40712 <at> debbugs.gnu.org (full text, mbox):

From: Rene <pacoon <at> protonmail.com>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: Raghav Gururajan <raghavgururajan <at> disroot.org>,
 "40712 <at> debbugs.gnu.org" <40712 <at> debbugs.gnu.org>
Subject: Re: [bug#40712] gnu: Add midori.
Date: Sun, 19 Apr 2020 17:26:43 +0000

Hello,


>
> Rene, would it be ok for your you if we merge Raghav patch?
>

go ahead, thanks for the patch.


Rene

Message #28 received at 40712-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: pacoon <at> protonmail.com, 40712-done <at> debbugs.gnu.org
Subject: Re: [bug#40712] gnu: Add midori. (v3)
Date: Mon, 20 Apr 2020 19:00:11 +0200

Hello,

> Here is the final revised patch. This works perfectly. I tried `./pre-inst-env
> guix environment --ad-hoc midori --pure` and `midori`.

I pushed it, with some line breaks and an edited synopsis and
description, to avoid camel case notation and superlatives.

Thanks to both of you,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.