GNU bug report logs - #40668
[PATCH] installer: Fix backtrace display.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: bug#40668: closed (Re: [bug#40668] [PATCH] installer: Fix
 backtrace display.)
Date: Sat, 18 Apr 2020 15:47:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#40668: [PATCH] installer: Fix backtrace display.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40668 <at> debbugs.gnu.org.

-- 
40668: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40668
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40668-done <at> debbugs.gnu.org
Subject: Re: [bug#40668] [PATCH] installer: Fix backtrace display.
Date: Sat, 18 Apr 2020 17:46:30 +0200

Hey,

> Please add (gnu installer utils) to the list of use-modules.
> ‘@@’ should only be used in extreme situations.

Fixed and pushed!

Thanks,

Mathieu

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] installer: Fix backtrace display.
Date: Thu, 16 Apr 2020 19:33:54 +0200

The 'syslog' macro cannot be resolved in the pre-unwind-handler
context. Failed to resolve 'syslog' in this context resulted in the swallowing
of all installation errors.

Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.

* gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
in the pre-unwind-handler.
---

Hello,

Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
this means that every error happening in the 1.1.0 release will result in an
installer restart, without any error information reporting. 

Thanks,

Mathieu

 gnu/installer.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/installer.scm b/gnu/installer.scm
index 1051ee1e5f..eba8a7d428 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -436,8 +436,9 @@ selected keymap."
                      #f)))
                 (const #f)
                 (lambda (key . args)
-                  (syslog "crashing due to uncaught exception: ~s ~s~%"
-                          key args)
+                  ((@@ (gnu installer utils) syslog)
+                   "crashing due to uncaught exception: ~s ~s~%"
+                   key args)
                   (let ((error-file "/tmp/last-installer-error"))
                     (call-with-output-file error-file
                       (lambda (port)
-- 
2.26.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.